Improve badge for click tracking and links #268
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tcbegley
reviewed
Oct 23, 2019
There was a problem hiding this comment.
Hey @miqh
Thanks so much for your contribution! Particularly for adding tests. I've somewhat neglected these to date as I've invested most of my time into improving documentation instead 😳 I definitely want to improve the state of the testing now that I'm mostly done with the docs for now.
I've made a couple of minor inline comments, really just for making this component consistent with other components that do similar things, specifically Button and DropdownMenuItem, and which I think helps readability a bit. If you are able to incorporate those I'd be happy to merge and include in the next release.
Thanks again for taking the time to contribute!
Extends the badge component to offer additional properties for tracking click interactions. Links are also rendered appropriately. Addresses #173
tcbegley
approved these changes
Oct 24, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
These changes aim to address the improvements suggested in #173.
I'm aware
n_clicks_timestampwasn't requested, but I figure I'd include it for consistency since most other components supportingn_clicksalso has the former.I transplanted the documentation for the new prop types from existing component implementations.
I've also introduced (couldn't find an existing one) a test file for the badge component that covers the new behaviour introduced.