Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert to psycopg2, and add instructions for no-binary install. #859

Merged
merged 2 commits into from
Mar 27, 2018

Conversation

j-bennet
Copy link
Contributor

@j-bennet j-bennet commented Mar 23, 2018

Revert to psycopg2 package insteaf of forcing psycopg2-binary.

For 2.7, this will install from wheels by default, and from source if --no-binary flag is used.

For 2.8, we need to figure out something else, since psycopg2 will become source only.

Related:
#849
#844

@j-bennet j-bennet requested a review from amjith March 23, 2018 18:17
@codecov-io
Copy link

codecov-io commented Mar 23, 2018

Codecov Report

Merging #859 into master will decrease coverage by 0.13%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #859      +/-   ##
==========================================
- Coverage   85.72%   85.58%   -0.14%     
==========================================
  Files          20       20              
  Lines        2290     2290              
==========================================
- Hits         1963     1960       -3     
- Misses        327      330       +3
Impacted Files Coverage Δ
pgcli/main.py 77.56% <0%> (-0.49%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7ea9102...b95ac55. Read the comment docs.

@j-bennet j-bennet removed the request for review from amjith March 27, 2018 15:40
@j-bennet j-bennet merged commit 6fe2c6a into master Mar 27, 2018
@j-bennet j-bennet deleted the j-bennet/revert-to-psycopg2 branch March 27, 2018 15:42
@j-bennet j-bennet mentioned this pull request Apr 24, 2018
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants