Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename psycopg2 to psycopg2-binary #867

Closed
wants to merge 3 commits into from
Closed

Rename psycopg2 to psycopg2-binary #867

wants to merge 3 commits into from

Conversation

gabfl
Copy link

@gabfl gabfl commented Apr 24, 2018

Description

The package psycopg2 is being renamed to psycopg2-binary and currently throws the following warning:

>>> import psycopg2
/usr/local/lib/python3.5/dist-packages/psycopg2/__init__.py:144: UserWarning: The psycopg2 wheel package will be renamed from release 2.8; in order to keep installing from binary please use "pip install psycopg2-binary" instead. For details see: <http://initd.org/psycopg/docs/install.html#binary-install-from-pypi>.

See more information at http://initd.org/psycopg/docs/install.html#binary-install-from-pypi

Checklist

  • I've added this contribution to the changelog.md.
  • I've added my name to the AUTHORS file (or it's already there).

@codecov-io
Copy link

codecov-io commented Apr 24, 2018

Codecov Report

Merging #867 into master will decrease coverage by 0.04%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #867      +/-   ##
==========================================
- Coverage   85.78%   85.73%   -0.05%     
==========================================
  Files          20       20              
  Lines        2314     2314              
==========================================
- Hits         1985     1984       -1     
- Misses        329      330       +1
Impacted Files Coverage Δ
pgcli/main.py 78.02% <0%> (-0.16%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f81243e...19d5657. Read the comment docs.

@j-bennet
Copy link
Contributor

j-bennet commented Apr 24, 2018

We already did this, for a brief period of time, in #846, and then reverted back in #859, because of #849.

As detailed in #849, there's a subset of users that can't run with psycopg2-binary installation. So we're currently not forcing it. This means that until 2.8 (first source-only version) is released, psycopg2 will spit out a warning. It's annoying, but at least it's not breaking things. Once 2.8 is released, the warning should go away. As far as I understand, users that wish to use psycopg2-binary will still be able to install that over psycopg2. If my understanding is not correct, we'll have to figure out a way for users to select binary vs source installation after 2.8 is out.

Thank you for the PR!

@j-bennet j-bennet closed this Apr 24, 2018
@gabfl
Copy link
Author

gabfl commented Apr 24, 2018

gotcha, thanks for the quick reply

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants