Fixing WiX UI extension screens: texts, icons, margins, spacing #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…en elements. Summary of changes: - Added a label (in bold) before input fields. - Fixed margins and space between elements. There were inconsitencies. - Fixed naming inconsistencies in code - e.g., strings in the .wxl for "ServiceCredDlg" started with "ServiceDlg_". - Merged into a unique text the 2 "description" labels in DbCreateCredDlg and RuntimeDbCredDlg. - Cleaned up unused strings, like texts for 'Browse' buttons that don't exist. - Created new error/success icons.
|
This is great. Can you please add a "Next Release" section to https://github.com/dblock/msiext/blob/master/CHANGELOG.md describing your changes? |
|
Done. If you think there should be more details in the change log, please let me know. |
dblock
added a commit
that referenced
this pull request
Feb 26, 2014
Fixing WiX UI extension screens: texts, icons, margins, spacing
|
Merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of changes:
Screenshots:
SelectDbDlg
DbCreateCredDlg
RuntimeDbCredDlg
ServiceCredDlg