[Fix] Conflict notifications map #147
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tuannguyensn2001
changed the title
maxdml
approved these changes
Sep 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Issue
The system database was using a single shared notificationsMap to handle both workflow notifications (
_DBOS_NOTIFICATIONS_CHANNEL) and workflow events (_DBOS_WORKFLOW_EVENTS_CHANNEL). This design could lead to potential conflicts when both channels used the same payload format (workflowID::topic), causing notifications intended for one channel to incorrectly trigger listeners on the other channel.Solution
Split the single notificationsMap into two separate maps:
workflowNotificationsMap- dedicated to handling workflow notificationsworkflowEventsMap- dedicated to handling workflow events