Starter examples: replace dbos-toolbox with dbos-go-starter #155
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maxdml
reviewed
Sep 26, 2025
maxdml
added a commit
that referenced
this pull request
Sep 26, 2025
maxdml
reviewed
Sep 26, 2025
Comment on lines
+74
to
+76
| if err := os.MkdirAll(filepath.Dir(outputPath), 0755); err != nil { | ||
| return fmt.Errorf("failed to create directory for %s: %w", outputFile, err) | ||
| } |
There was a problem hiding this comment.
Why is this needed? os.Write will create the folders is needed
There was a problem hiding this comment.
in templates map, we have this entry:
"templates/dbos-go-starter/app.html": "html/app.html",when outputFile is "html/app.html", filepath.Dir(outputPath) will resolve to "dbos-go-starter/html". The os.MkdirAll call then ensures that the html subdirectory is created inside the main project directory before os.WriteFile attempts to create app.html within it
so without the os.MkdirAll, we will get:
./dbos init
Error: failed to write html/app.html: open dbos-go-starter/html/app.html: no such file or directory
Co-authored-by: Max dml <maxdemoulin@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Hi, thanks for the great project, I am currently trying to demo this my team but the current example sucked. So i went ahead and replace it with the dbos-go-starter.