task callsites: part 2 #4188
Merged
task callsites: part 2 #4188
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emmyoop
commented
Nov 2, 2021
emmyoop
commented
Nov 2, 2021
emmyoop
commented
Nov 2, 2021
nathaniel-may
suggested changes
Nov 3, 2021
core/dbt/task/freshness.py
Outdated
Comment on lines
44
to
73
| if hasattr(result, 'node'): | ||
| source_name = result.node.source_name | ||
| table_name = result.node.name | ||
| else: | ||
| source_name = result.source_name | ||
| table_name = result.table_name | ||
| if result.status == FreshnessStatus.RuntimeErr: | ||
| fire_event(PrintHookEndErrorLine(source_name=source_name, | ||
| table_name=table_name, | ||
| index=self.node_index, | ||
| total=self.num_nodes, | ||
| execution_time=result.execution_time)) | ||
| elif result.status == FreshnessStatus.Error: | ||
| fire_event(PrintHookEndErrorStaleLine(source_name=source_name, | ||
| table_name=table_name, | ||
| index=self.node_index, | ||
| total=self.num_nodes, | ||
| execution_time=result.execution_time)) | ||
| elif result.status == FreshnessStatus.Warn: | ||
| fire_event(PrintHookEndWarnLine(source_name=source_name, | ||
| table_name=table_name, | ||
| index=self.node_index, | ||
| total=self.num_nodes, | ||
| execution_time=result.execution_time)) | ||
| else: | ||
| fire_event(PrintHookEndPassLine(source_name=source_name, | ||
| table_name=table_name, | ||
| index=self.node_index, | ||
| total=self.num_nodes, | ||
| execution_time=result.execution_time)) |
There was a problem hiding this comment.
this looks like it was pretty non-trivial to change. I really like what you did with it here: It brings the important stuff to the top, and buries the stuff we don't care about as much. Nice job.
emmyoop
added a commit
that referenced
this pull request
Nov 8, 2021
* add struct logging to docs serve * remove merge fluff * struct logging to seed command * converting print to use structured logging * more structured logging print conversion * pulling apart formatting more * added struct logging by disecting printer.py * add struct logging to runnable * add struct logging to task init * fixed formatting * more formatting and moving things around
emmyoop
added a commit
that referenced
this pull request
Nov 8, 2021
* add struct logging to docs serve * remove merge fluff * struct logging to seed command * converting print to use structured logging * more structured logging print conversion * pulling apart formatting more * added struct logging by disecting printer.py * add struct logging to runnable * add struct logging to task init * fixed formatting * more formatting and moving things around
kwigley
pushed a commit
that referenced
this pull request
Nov 9, 2021
* add struct logging to docs serve * remove merge fluff * struct logging to seed command * converting print to use structured logging * more structured logging print conversion * pulling apart formatting more * added struct logging by disecting printer.py * add struct logging to runnable * add struct logging to task init * fixed formatting * more formatting and moving things around
nathaniel-may
pushed a commit
that referenced
this pull request
Nov 9, 2021
* add struct logging to docs serve * remove merge fluff * struct logging to seed command * converting print to use structured logging * more structured logging print conversion * pulling apart formatting more * added struct logging by disecting printer.py * add struct logging to runnable * add struct logging to task init * fixed formatting * more formatting and moving things around
iknox-fa
pushed a commit
that referenced
this pull request
Feb 8, 2022
* add struct logging to docs serve * remove merge fluff * struct logging to seed command * converting print to use structured logging * more structured logging print conversion * pulling apart formatting more * added struct logging by disecting printer.py * add struct logging to runnable * add struct logging to task init * fixed formatting * more formatting and moving things around automatic commit by git-black, original commits: 3cafc9e
iknox-fa
pushed a commit
that referenced
this pull request
Feb 8, 2022
* add struct logging to docs serve * remove merge fluff * struct logging to seed command * converting print to use structured logging * more structured logging print conversion * pulling apart formatting more * added struct logging by disecting printer.py * add struct logging to runnable * add struct logging to task init * fixed formatting * more formatting and moving things around automatic commit by git-black, original commits: 3cafc9e 73f7fba
iknox-fa
pushed a commit
that referenced
this pull request
Feb 8, 2022
* add struct logging to docs serve * remove merge fluff * struct logging to seed command * converting print to use structured logging * more structured logging print conversion * pulling apart formatting more * added struct logging by disecting printer.py * add struct logging to runnable * add struct logging to task init * fixed formatting * more formatting and moving things around automatic commit by git-black, original commits: 3cafc9e 9cc7a7a
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Modifying call sites for structured logging in core/dbt/task
#4183 is Part 1 of the same dir
Checklist
CHANGELOG.mdand added information about my change