-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
scrub the secrets #4203
scrub the secrets #4203
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good - FYI there's a commit in the main branch ahead of when this branched off that uses scrubbing in exceptions.py
Tests also import |
Thanks for the heads up @emmyoop. It looks like the commit in |
scrub secrets in event module
Description
Uses the same strategy that we use today via LogBook just via a simple function call. I decided not to use the built-in scrubbing from structlog because it's made to scrub named fields, which we are not doing here. We only have the values.
Checklist
CHANGELOG.md
and added information about my change