Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Store a list of input WhereFilterSpecs in the WhereConstraintNode #1277

Merged
merged 1 commit into from
Jun 25, 2024

Commits on Jun 25, 2024

  1. Store a list of input WhereFilterSpecs in the WhereConstraintNode

    Up until now we've been merging sets of WhereFilterSpec instances
    into a single instance and then storing that in the WhereConstraintNode.
    
    This made sense for rendering, but when trying to do predicate pushdown
    having the specs all merged together limits the space of filter pushdown
    opporunities. In order to allow for the same breadth of predicate pushdown
    opportunities we have at dataflow plan build time we keep the specs separate,
    and encapsulate the merging of these specs into the WhereConstraintNode itself.
    tlento committed Jun 25, 2024
    Configuration menu
    Copy the full SHA
    ad0298d View commit details
    Browse the repository at this point in the history