-
Notifications
You must be signed in to change notification settings - Fork 89
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Store a list of input WhereFilterSpecs in the WhereConstraintNode #1277
Open
tlento
wants to merge
1
commit into
06-11-enable_dataflowplanoptimizers_for_query_rendering_tests
Choose a base branch
from
consolidate-where-filter-merging
base: 06-11-enable_dataflowplanoptimizers_for_query_rendering_tests
Could not load branches
Branch not found: {{ refName }}
Could not load tags
Nothing to show
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Store a list of input WhereFilterSpecs in the WhereConstraintNode #1277
tlento
wants to merge
1
commit into
06-11-enable_dataflowplanoptimizers_for_query_rendering_tests
from
consolidate-where-filter-merging
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Up until now we've been merging sets of WhereFilterSpec instances into a single instance and then storing that in the WhereConstraintNode. This made sense for rendering, but when trying to do predicate pushdown having the specs all merged together limits the space of filter pushdown opporunities. In order to allow for the same breadth of predicate pushdown opportunities we have at dataflow plan build time we keep the specs separate, and encapsulate the merging of these specs into the WhereConstraintNode itself.
Thank you for your pull request! We could not find a changelog entry for this change. For details on how to document a change, see the contributing guide. |
This was referenced Jun 14, 2024
This was referenced Jun 14, 2024
courtneyholcomb
approved these changes
Jun 14, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Up until now we've been merging sets of WhereFilterSpec instances
into a single instance and then storing that in the WhereConstraintNode.
This made sense for rendering, but when trying to do predicate pushdown
having the specs all merged together limits the space of filter pushdown
opporunities. In order to allow for the same breadth of predicate pushdown
opportunities we have at dataflow plan build time we keep the specs separate,
and encapsulate the merging of these specs into the WhereConstraintNode itself.