switch to new adapter test framework #216
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
dataders
commented
Apr 20, 2022
•
dataders
commented
- Uses new test adapter framework created by dbt Labs
- Uses tox for all tests
- Moves tests from Circle CI to GitHub actions
- Fixes issue with duplicate column names in tempdb
ChenyuLInx
reviewed
Apr 21, 2022
This reverts commit 8061a66.
|
We should probably look into the thing where a table appears multiple times in tempdb but from a different schema. |
dataders
commented
May 26, 2022
| @@ -17,7 +17,7 @@ | |||
| from [{{ relation.database }}].INFORMATION_SCHEMA.COLUMNS | |||
| where table_name = '{{ relation.identifier }}' | |||
| and table_schema = '{{ relation.schema }}' | |||
| UNION ALL | |||
There was a problem hiding this comment.
OMG WOW great find!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.