Skip to content

In-screen error reporting #108

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 4, 2022
Merged

In-screen error reporting #108

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
39 changes: 31 additions & 8 deletions src/plotly-graph-card.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -118,6 +118,8 @@ export class PlotlyGraph extends HTMLElement {
color: red;
top: 0;
background: rgba(0, 0, 0, 0.4);
overflow-wrap: break-word;
width: 100%;
}
</style>
<div id="title"> </div>
Expand Down Expand Up @@ -227,10 +229,14 @@ export class PlotlyGraph extends HTMLElement {
return await this._setConfig(config);
} catch (e: any) {
console.error(e);
this.msgEl.innerText = JSON.stringify(e.message || "").replace(
/\\"/g,
'"'
);
if (typeof e.message === "string") {
this.msgEl.innerText = e.message;
} else {
this.msgEl.innerText = JSON.stringify(e.message || "").replace(
/\\"/g,
'"'
);
}
}
}
async _setConfig(config: InputConfig) {
Expand All @@ -241,7 +247,16 @@ export class PlotlyGraph extends HTMLElement {
? schemeName
: colorSchemes[schemeName] ||
colorSchemes[Object.keys(colorSchemes)[schemeName]] ||
colorSchemes.category10;
null;
if (colorScheme === null) {
throw new Error(
`color_scheme: "${
config.color_scheme
}" is not valid. Valid are an array of colors (see readme) or ${Object.keys(
colorSchemes
)}`
);
}
const newConfig: Config = {
title: config.title,
hours_to_show: config.hours_to_show ?? 1,
Expand Down Expand Up @@ -269,8 +284,11 @@ export class PlotlyGraph extends HTMLElement {
}
if ("statistic" in entity || "period" in entity) {
const validStatistic = STATISTIC_TYPES.includes(entity.statistic!);
if (!validStatistic) entity.statistic = "mean";
console.log(entity.period);
if (entity.statistic === undefined) entity.statistic = "mean";
else if (!validStatistic)
throw new Error(
`statistic: "${entity.statistic}" is not valid. Use ${STATISTIC_TYPES}`
);
// @TODO: cleanup how this is done
if (entity.period === "auto") {
entity.autoPeriod = {
Expand All @@ -285,9 +303,14 @@ export class PlotlyGraph extends HTMLElement {

if (isAutoPeriodConfig) {
entity.autoPeriod = entity.period;
entity.period = undefined;
}
const validPeriod = STATISTIC_PERIODS.includes(entity.period);
if (!validPeriod) entity.period = "hour";
if (entity.period === undefined) entity.period = "hour";
else if (!validPeriod)
throw new Error(
`period: "${entity.period}" is not valid. Use ${STATISTIC_PERIODS}`
);
}
const [oldAPI_entity, oldAPI_attribute] = entity.entity.split("::");
if (oldAPI_attribute) {
Expand Down