Skip to content

Conversation

zanna-37
Copy link
Contributor

With this new action the project is compiled every time a new release is published and the output file is attached to it. No need to compile manually and create a commit for it.
If you decide to use this I suggest you to delete the dist folder from the repo and add it to the .gitignore.

No changes for HACS, everything continue to work.

The project is compiled every time a new release is published and the output file is attached to it.
@dbuezas
Copy link
Owner

dbuezas commented Nov 14, 2022

This is awesome!

@dbuezas
Copy link
Owner

dbuezas commented Nov 14, 2022

I think this will also put a download counter in hacs.

@zanna-37
Copy link
Contributor Author

I think this will also put a download counter in hacs.

Yes, a counter for the earliest release. ☺️

@dbuezas
Copy link
Owner

dbuezas commented Nov 14, 2022

Yes, a counter for the earliest release. ☺️

What do you mean with "the earliest" ?

@dbuezas
Copy link
Owner

dbuezas commented Nov 14, 2022

BTW, my manual workflow was to call npm version patch(or minor or major) and an npm hook builds it. This is better, but it wasn't that bad

@zanna-37
Copy link
Contributor Author

What do you mean with "the earliest" ?

The download counter in HACS resets at every new release.

This is better, but it wasn't that bad

Yeah, not saying it was bad. The advantage is that you avoid having a commit just for the built library.
By the way, I created the action so that I could test your latest changes by creating a release in my private fork without the need to compile it myself (and needing a computer). 😂 Then I thought you might appreciate it as well, so I PR it. 👍🏻

If you don't need it, feel free to reject the PR, no offense. I literally almost copied the action I use for mine, so a 5 minutes effort for me.

@dbuezas
Copy link
Owner

dbuezas commented Nov 14, 2022

If you don't need it, feel free to reject the PR, no offense.

I don't need this. I want it! :)

I wanted to do this for a long while, but never broke the "have to learn first" barrier.

Where did you learn how to do this?

@zanna-37
Copy link
Contributor Author

Same way I learnt ~90% of what I know. I want it and I'm not giving up until it's done. 😂

Jokes aside, github can be a wonderful place, people usually share a lot of problems and some solve them before others. It's just a matter of getting lost in projects and being curious.
And internet is full of good documentation and guides.

The only thing difficult is having free time, because "getting lost" requires a lot of it. 😂

TL;DR
I'm a very curious person, and I like to discover how people (more knowledgeable than me) do stuff and then take inspiration. 😉

@dbuezas
Copy link
Owner

dbuezas commented Nov 14, 2022

Same as me. So copy & paste? 🤣

@zanna-37
Copy link
Contributor Author

zanna-37 commented Nov 14, 2022

In my experience, it rarely is that easy.
It's:

  • copy
  • paste
  • StackOverflow
  • search on GitHub to see if someone is doing the same
  • realize that you'd better read the docs
  • accept that you need to understand the pasted code
  • doing a better version that fits your needs

It always starts as a "well, it can't be that difficult" and ends with "I made so many mistakes that I'm now an expert" 😂

dbuezas added a commit that referenced this pull request Nov 15, 2022
@dbuezas dbuezas merged commit 28dc3b4 into dbuezas:master Nov 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants