Skip to content
This repository was archived by the owner on Oct 27, 2024. It is now read-only.

Conversation

tiloio
Copy link
Contributor

@tiloio tiloio commented Oct 8, 2024

The current new URL(import.meta.url).pathname will not resolve to the current path if we use deno compile.

The current "new URL(import.meta.url).pathname" will not resolve to the current path if we use deno compile.
@dbushell
Copy link
Owner

dbushell commented Oct 9, 2024

Thanks this is interesting, does deno compile allow you to bundle the entire Svelte Kit build and web server into a single binary?

I think This PR change is going to break normal deployments. Deno.execPath() docs say:

console.log(Deno.execPath());  // e.g. "/home/alice/.local/bin/deno"

I guess that points to the compiled binary in your use case?

For normal deployment it needs to point to the build output directory.

Maybe there is a way to conditionally check if it's compiled before setting baseDir. Or we'd need to extend AdapterOptions to do it at build time.

@tiloio
Copy link
Contributor Author

tiloio commented Oct 9, 2024

I introduced the usage option (see READM.md). This should work for everyone :).�

@dbushell
Copy link
Owner

Thanks I'll try and test and get this merge soon.

@dbushell dbushell merged commit 35004d4 into dbushell:main Oct 11, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants