Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Map change: remove the buffer overlap #117

Closed
WABA-Comms opened this issue Sep 2, 2016 · 6 comments
Closed

Map change: remove the buffer overlap #117

WABA-Comms opened this issue Sep 2, 2016 · 6 comments
Assignees
Labels

Comments

@WABA-Comms
Copy link
Collaborator

We're looking to prevent buffers from overlapping when they cross jurisdictional lines to avoid the intestinal look.

Possible with modifying svg directly: Pull all paths into a single instead of multiple nodes. A little tedious, might be slow.

@WABA-Comms WABA-Comms added this to the Bike Hack Night milestone Sep 2, 2016
@mdelcambre
Copy link
Collaborator

A simple (from a coding/technology side) solution is to limit the buffers to only be within the county borders. This would automatically prevent any overlap from showing.
However, it may look a bit strange when the neighbor county is not loaded, but perhaps that is acceptable. Given that we have the county lines, it should be pretty to easy for a user to understand what is going on. Maybe argue it is a feature as it only gives a county credit for their own coverage 😉 .

@alongthepike
Copy link
Collaborator

I like @mdelcambre's recommendation. This could be as simple as calling turf.intersect passing it the buffer polygon and the county border polygon before saving the buffer.

And yes, this is definitely of use when we are calculating % of the jurisdiction's land area that is within X distance of bike infrastructure. Right now Arlington's "% of jurisdiction within 1 mile of bike infrastructure" is calculating as over 100% because the buffer polygon extends beyond the actual jurisdiction.

@alongthepike
Copy link
Collaborator

proofofconcept

Proof of concept looks very promising.

@WABA-Comms
Copy link
Collaborator Author

woah, DC boundary extends west of the potomac? #Themoreyouknow

[image: Inline image 1]

Nelle Pierson *| *Deputy Director *
*Washington Area Bicyclist Association

2599 Ontario Rd NW Washington DC, 20009
Desk: 202-518-0524 x 202
Cell: 848-863-9442

Your membership results in better bike rides. Click here
http://www.waba.org/get-involved/become-a-member/to join or renew your
WABA membership.

On Fri, Sep 2, 2016 at 3:28 PM, Chris Slatt notifications@github.com
wrote:

[image: proofofconcept]
https://cloud.githubusercontent.com/assets/13531063/18215953/ebd028a0-7121-11e6-916f-93d80657f7ac.png

Proof of concept looks very promising.


You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
#117 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/AT0U7ZZI5CL8aD4JrFC-ageQsrhKZZOxks5qmHjwgaJpZM4JzowZ
.

@alongthepike
Copy link
Collaborator

Yep. DC owns ALL of the water and everything in it - TR Island is DC, Memorial Circle is DC.

@alulsh
Copy link
Member

alulsh commented Sep 7, 2016

This was done in #131! 🎉

@alulsh alulsh closed this as completed Sep 7, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants