Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

trackingMode is a char and so should be strcmp'ed #12

Closed
wants to merge 1 commit into from

Conversation

iandol
Copy link
Contributor

@iandol iandol commented Dec 16, 2019

small fix

@@ -4,7 +4,7 @@
% Titta can be found at https://github.com/dcnieho/Titta. Check there for
% the latest version.
% When using Titta, please cite the following paper:
% Niehorster, D.C., Andersson, R. & Nystr�m, M., (in prep). Titta: A
% Niehorster, D.C., Andersson, R. & Nystr�m, M., (in prep). Titta: A
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

encoding conversion problem, not sure how I can stop it so you may need to fix it in your encoding mode

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The files are encoded in WINDOWS-1252 I think. I have been trying to convert them to utf8, but that does not yield anything committable, so i'm kinda at a loss here. On top of that, it seems that the matlab editor is not unicode-aware from my reading, so saving files there will mess it up anyway. I guess I'm simply replacing ö with o...
Do you have a better idea about this?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, the problem rests firmly with Mathworks inability to update to a UTF8 capable editor, so I just remove non-essential characters, but as I work in China, often colleagues comment in chinese and that breaks in my editor too. I normally just make small edits in VS Code where I can switch encoding as necessary. For this pull I didn't realise until after the commit...

The nerdy solution would be that git can automate scripts to perform encoding conversions automagically but I think it isn't worth the effort to develop that either...

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually you may be able to force the use of UTF-8 on Windows:

www.mathworks.com/matlabcentral/answers/280988-how-do-i-get-my-matlab-editor-to-read-utf-8-characters-utf-8-characters-in-blank-squares-in-editors

On my mac, at least under 2019b utf-8 is the default now... You could batch convert all files using iconv or something similar.

@dcnieho dcnieho closed this in 92f5463 Dec 16, 2019
@dcnieho
Copy link
Owner

dcnieho commented Dec 16, 2019 via email

dcnieho added a commit that referenced this pull request Dec 16, 2019
…racter completely across windows and Linux when matlab editor does not do UTF8, See #12
@iandol iandol deleted the fix1 branch December 16, 2019 22:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants