-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
trackingMode is a char and so should be strcmp'ed #12
Conversation
@@ -4,7 +4,7 @@ | |||
% Titta can be found at https://github.com/dcnieho/Titta. Check there for | |||
% the latest version. | |||
% When using Titta, please cite the following paper: | |||
% Niehorster, D.C., Andersson, R. & Nystr�m, M., (in prep). Titta: A | |||
% Niehorster, D.C., Andersson, R. & Nystr�m, M., (in prep). Titta: A |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
encoding conversion problem, not sure how I can stop it so you may need to fix it in your encoding mode
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The files are encoded in WINDOWS-1252 I think. I have been trying to convert them to utf8, but that does not yield anything committable, so i'm kinda at a loss here. On top of that, it seems that the matlab editor is not unicode-aware from my reading, so saving files there will mess it up anyway. I guess I'm simply replacing ö with o...
Do you have a better idea about this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No, the problem rests firmly with Mathworks inability to update to a UTF8 capable editor, so I just remove non-essential characters, but as I work in China, often colleagues comment in chinese and that breaks in my editor too. I normally just make small edits in VS Code where I can switch encoding as necessary. For this pull I didn't realise until after the commit...
The nerdy solution would be that git can automate scripts to perform encoding conversions automagically but I think it isn't worth the effort to develop that either...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actually you may be able to force the use of UTF-8 on Windows:
On my mac, at least under 2019b utf-8 is the default now... You could batch convert all files using iconv or something similar.
Thanks! That exactly the post i read too, based on which i decided that
utf8 was a bad idea. 2019b on Win10 gives me 'windows-1252' as encoding.
The other issue that i had was that converting Titta.m using iconv to utf
(`iconv -f CP1252 -t utf-8`) didn't create any committable change to the
file.
Just talk to the one and only Nyström, he's fine if i simply turn his name
into Nystrom, which will fix it :p
Cheers and thanks for the thoughts,
Dee
…On Mon, Dec 16, 2019 at 9:43 AM Ian Max Andolina ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In Titta.m
<#12 (comment)>:
> @@ -4,7 +4,7 @@
% Titta can be found at https://github.com/dcnieho/Titta. Check there for
% the latest version.
% When using Titta, please cite the following paper:
-% Niehorster, D.C., Andersson, R. & Nystr�m, M., (in prep). Titta: A
+% Niehorster, D.C., Andersson, R. & Nystr�m, M., (in prep). Titta: A
Actually you may be able to force the use of UTF-8 on Windows:
www.mathworks.com/matlabcentral/answers/280988-how-do-i-get-my-matlab-editor-to-read-utf-8-characters-utf-8-characters-in-blank-squares-in-editors
On my mac, at least under 2019b utf-8 is the default now... You could
batch convert all files using iconv or something similar.
—
You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHub
<#12?email_source=notifications&email_token=AANUOGLIDAGVRQRNBLV3JJLQY45SJA5CNFSM4J3EEEF2YY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOCPICCAY#discussion_r358106564>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AANUOGJAITRUFGBAQEMCAATQY45SJANCNFSM4J3EEEFQ>
.
|
…racter completely across windows and Linux when matlab editor does not do UTF8, See #12
small fix