This repository was archived by the owner on Jun 5, 2020. It is now read-only.
Specify versions of dependencies #2
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I'm repeatedly getting issues with npm-shrinkwrap with the `"latest"` version specifiers used for `colour` and `optjs`. This is fine for `devDependencies`, but for some reason doesn't work properly for real dependencies. Changing this to more specific version numbers should help for this.
|
Yes related to npm issue: npm/npm#9703 |
|
I agree, I keep hitting this too. Sure, it's an npm bug but fixing this and publishing would work around it. |
|
This is also npm/npm#13642 |
glasser
added a commit
to apollographql/protobuf.js
that referenced
this pull request
Oct 13, 2016
Our project only needs to use the loadProto API from protobufjs, not the CLI. The ascli package uses strange @latest dependencies which trigger some bugs in npm. So this package lets us depend on protobufjs without pulling in the ascli dependency. A PR to fix ascli is at dcodeIO/ascli#2 The underlying bug seems to be tracked at npm/npm#13642
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm repeatedly getting issues with npm-shrinkwrap with the
"latest"version specifiers used forcolourandoptjs. This is fine fordevDependencies, but for some reason doesn't work properly for real dependencies. Changing this to more specific version numbers should help for this.