XOAUTH2 #53
Open
XOAUTH2 #53
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…to elberskirch-master
In GMail
- Fix #labels on non-gmail accounts - stop assuming that the "[Gmail]"
hierachy exists
- Add #imap_xlist
- Monkey patches XLIST support into Net::IMAP if it's missing.
- Caches result until a new label is created
- Add #inbox_label, #allmail_label, #spam_label, #trash_label,
#drafts_label, #important_label, #starred_label
- Uses XLIST to identify function of standard folders
- Add #inbox, #allmail, #spam, #trash, #drafts, #important, #starred,
#sent
- Short cuts to known mailboxes
- Add #normal_labels
- Returns list of "normal" labels - ie. not sent, etc.
- Add #label_of_type(type)
- Looks up known mailbox
In GMail::Mailbox
- In #emails
- Add support for additional all IMAP search keywords via hash params
to #emails().
- Throw runtime error for unknown keys
In GMail::Message
- Add #message_id
- UIDs are different for the same message across different folders,
so Message-ID header is the test for uniqueness
- Add #has_label?(name)
- Indicates whether message has given label applied
- Add #archived?, #starred?, #sent?, #important?
- Shortcuts to check whether the message has been archived, starred
etc.
- Add #labels - returns list of labels applied to message
- Search all known folders for messages with this message-id
- Add #remove_label(label) - deletes message from given mailbox/label
- ie. delete message from named folder
In Gmail::Mailbox - Add support for :fetch key in #emails() to indicate the message bodies should be fetched In Gmail::Mail - Add #loaded? to check whether message has already been downloaded - Add #set_body(body) to set the contents of a message
GMail::Message - Add #envelope to store/read back imap envelope contents - Add #message_id? to check whether we know the message id yet - Add #subject, #from, #to to read values from envelope with body fallback GMail::Mailbox - Change behaviour - always fetch IMAP ENVELOPE for search results unless we have already loaded message - Add GMail::Mailbox::MessageList - array like class for search results - Add MessageList#with_label(label) - filter results - Searches label folder for messages in MessageList
|
I am not sure if I'll be able to merge this. With so many changes and no updated specs it seems like it could be disastrous since I don't understand all of it. Do you want to work together to spec this out? |
|
yeah sure, but it is not that complex, actually it is just an extra string I think is missing |
|
Oh, when I look at the diff here on github there are a lot of changes. Do you have a simpler example of what you need? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have changes to support XOAUTH2