Introduce steps

.scrutinizer.yml

@@ -0,0 +1,2 @@
+tools:
+    external_code_coverage: true

.travis.yml

@@ -2,8 +2,7 @@ language: php
 
 sudo: false
 
-php:
-  - 5.3
+php: 
   - 5.4
   - 5.5
   - 5.6
@@ -17,7 +16,7 @@ matrix:
 
 cache:
   directories:
-    - $HOME/.composer/cache    
+    - $HOME/.composer/cache
 
 before_script:
   - sh -c "if [ \"$TRAVIS_PHP_VERSION\" == \"hhvm\" ]; then composer require --dev mongofill/mongofill=dev-master --no-update; fi"

composer.json

@@ -18,7 +18,7 @@
         "source": "https://github.com/ddeboer/data-import"
     },
     "require": {
-        "php": ">=5.3.0",
+        "php": ">=5.4.0",
         "psr/log": "~1.0"
     },
     "require-dev": {

phpunit.xml.dist

@@ -1,6 +1,6 @@
 <?xml version="1.0" encoding="UTF-8"?>
 
-<phpunit bootstrap="./tests/bootstrap.php" colors="true">
+<phpunit bootstrap="./tests/bootstrap.php" colors="true" convertErrorsToExceptions="true">
     <testsuites>
         <testsuite name="ddeboer/data-import">
             <directory suffix="Test.php">./tests</directory>
@@ -15,4 +15,4 @@
             </exclude>
         </whitelist>
     </filter>
-</phpunit>
+</phpunit>

src/Ddeboer/DataImport/Exception/MappingException.php

@@ -0,0 +1,13 @@
+<?php
+
+namespace Ddeboer\DataImport\Exception;
+
+/**
+ * Description of MappingException
+ *
+ * @author gnat
+ */
+class MappingException extends \Exception implements ExceptionInterface
+{
+
+}

src/Ddeboer/DataImport/Filter/DateTimeThresholdFilter.php

@@ -8,11 +8,11 @@
  * This filter can be used to filter out some items from a specific date. Useful
  * to do incremental imports
  */
-class DateTimeThresholdFilter implements FilterInterface
+class DateTimeThresholdFilter
 {
     /**
-     * @var DateTime threshold dates strictly before this date will be filtered out.
-     *               defaults to null
+     * @var \DateTime threshold dates strictly before this date will be filtered out.
+     *                defaults to null
      */
     protected $threshold;
 
@@ -47,14 +47,14 @@ public function __construct(
     /**
      * {@inheritDoc}
      */
-    public function filter(array $item)
+    public function __invoke(array $item)
     {
         if ($this->threshold == null) {
             throw new \LogicException('Make sure you set a threshold');
         }
 
         return
-            $this->valueConverter->convert($item[$this->timeColumnName])
+            call_user_func($this->valueConverter, $item[$this->timeColumnName])
             >=
             $this->threshold;
     }
@@ -69,12 +69,4 @@ public function setThreshold(\DateTime $value)
 
         return $this;
     }
-
-    /**
-     * {@inheritdoc}
-     */
-    public function getPriority()
-    {
-        return $this->priority;
-    }
 }

src/Ddeboer/DataImport/Filter/OffsetFilter.php

@@ -8,7 +8,7 @@
  *
  * @author Ville Mattila <ville@eventio.fi>
  */
-class OffsetFilter implements FilterInterface
+class OffsetFilter
 {
     /**
      * @var int
@@ -50,7 +50,7 @@ public function __construct($offset = 0, $limit = null)
     /**
      * {@inheritDoc}
      */
-    public function filter(array $item)
+    public function __invoke(array $item)
     {
         // In case we've already filtered up to limited
         if ($this->maxLimitHit) {
@@ -81,12 +81,4 @@ public function filter(array $item)
 
         return false;
     }
-
-    /**
-     * {@inheritdoc}
-     */
-    public function getPriority()
-    {
-        return 128;
-    }
 }

src/Ddeboer/DataImport/Filter/ValidatorFilter.php

@@ -7,7 +7,7 @@
 use Symfony\Component\Validator\Constraints;
 use Ddeboer\DataImport\Exception\ValidationException;
 
-class ValidatorFilter implements FilterInterface
+class ValidatorFilter
 {
     private $validator;
 
@@ -50,7 +50,7 @@ public function getViolations()
         return $this->violations;
     }
 
-    public function filter(array $item)
+    public function __invoke(array $item)
     {
         if (!$this->strict) {
             // Only validate properties which have an constaint.
@@ -72,12 +72,4 @@ public function filter(array $item)
 
         return 0 === count($list);
     }
-
-    /**
-     * {@inheritdoc}
-     */
-    public function getPriority()
-    {
-        return 256;
-    }
 }