Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Step priority overridden #293

Closed
ghost opened this issue May 23, 2016 · 3 comments
Closed

Step priority overridden #293

ghost opened this issue May 23, 2016 · 3 comments

Comments

@ghost
Copy link

ghost commented May 23, 2016

When using StepAggregator::addStep($step, $priority), the priority argument is always overridden and set to null.
ghost pushed a commit to mattrq/data-import that referenced this issue May 23, 2016
@mattrq
Fix Step priorities ddeboer#293
452d472
@ghost
Copy link
Author

ghost commented May 23, 2016

Please find a suggested fix in pull request: #294

@ghost ghost closed this as completed May 23, 2016
@ghost ghost reopened this May 23, 2016
@ghost
Copy link
Author

ghost commented May 23, 2016

Sorry, closed accidentally

ddeboer pushed a commit that referenced this issue Jun 9, 2016
@mattrq @ddeboer
Fix Step priorities #293 (#294)
9fb9571 
* Fix Step priorities #293

* Update StepAggregator.php
@ddeboer
Copy link
Owner

ddeboer commented Jun 9, 2016 •
edited
Loading

Merged, thanks! 😄

@ddeboer ddeboer closed this as completed Jun 9, 2016
@ddeboer ddeboer mentioned this issue Jun 9, 2016
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@ddeboer