CSVReader::current() avoid recursion #101
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Interesting. Can you add a test case that makes the original implementation fail? |
|
@ddeboer Hope https://github.com/boekkooi/data-import/commit/813cebded8ab7ca4716e57e96c7cd1017c417d6a is good enough. It's not a great test but it will fail with the old implementation and work with the new one. |
|
@boekkooi Cany you push the testcase to this PR? |
|
@Baachi You mean combine the 2 commits? since they are both already in the PR. |
|
Ah my fault, sorry. I didn't see that you already pushed it 😅 |
Baachi
added a commit
that referenced
this pull request
Jul 25, 2014
CSVReader::current() avoid recursion
|
@Baachi No problem thanks for the merge! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current CSVReader is using recursion when a row is invalid this may cause a
Fatal error: Maximum function nesting levelwhen using a file with a lot of invalid rows.To avoid this a do while is introduced and the
$this->current()call is removed.