Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change EntityManager to EntityManagerInterface #193

Merged
merged 2 commits into from
Apr 29, 2015
Merged

Conversation

ip512
Copy link
Contributor

@ip512 ip512 commented Apr 28, 2015

No description provided.

@ddeboer
Copy link
Owner

ddeboer commented Apr 28, 2015

EntityManagerInterface was introduced in Doctrine 2.4, so we should change our require-dev to that. Can you change our composer.json, too?

@Baachi Are you okay with dropping support for Doctrine < 2.4?

@Baachi
Copy link
Collaborator

Baachi commented Apr 28, 2015

Why not rather require the Doctrine\Common\ObjectManager interface. It will do the same and we didn't need to bump the doctrine version.

@ddeboer
Copy link
Owner

ddeboer commented Apr 28, 2015

@Baachi We use getConnection() and getReference(), and those methods are only available on EntityManagerInterface, not ObjectManager.

@Baachi
Copy link
Collaborator

Baachi commented Apr 28, 2015

Ah didn't see that. Okay then i'm okay with bump the version to 2.4. 👍

@ddeboer
Copy link
Owner

ddeboer commented Apr 29, 2015

@ip512 Could you adapt our composer.json to require Doctrine ~2.4? Thanks!

@ip512
Copy link
Contributor Author

ip512 commented Apr 29, 2015

@ddeboer it's done

ddeboer added a commit that referenced this pull request Apr 29, 2015
Change EntityManager to EntityManagerInterface
@ddeboer ddeboer merged commit 45069d8 into ddeboer:master Apr 29, 2015
@ddeboer
Copy link
Owner

ddeboer commented Apr 29, 2015

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants