-
Notifications
You must be signed in to change notification settings - Fork 123
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use Symfony 2.5 ProgressBar Helper + allow option to set verbosity #73
Conversation
Hi, thanks! Yep, let's wait until 2.5 is stable. Alternatively, we could introduce your updated writer as a separate class, e.g., |
Would be nice to get it in so we don't have to maintain our own fork, so If you're cool with me providing a separate |
Yes! |
"symfony/validator": "~2.3.0" | ||
"symfony/console": "v2.5.0-BETA2", | ||
"symfony/validator": "~2.3.0", | ||
"phpunit/phpunit": "4.*" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Noticed you added PHPUnit. Is this really necessary for the test to work?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No not really, My global version was complaining about something, so I just installed it locally. I'll remove it!
So which version of In fact, not sure this will work as we can't test on multiple versions - and it seems some of the other |
Hmm, yes, that's unfortunate. Can we agree to leave this updated version out until 2.5 is stable and we can switch to that for |
Yeah no problem, I'll just use my fork for a bit :) |
Changed this to stable 2.5 and re-based. Should be good to merge now that 2.5 has gone stable. This will fix the tests also. |
Hmm, can you re-rebase? :) |
Done :) |
Use Symfony 2.5 ProgressBar Helper + allow option to set verbosity
Thanks! |
Hey, I've updated the ConsoleProgressWriter to use a new Symfony 2.5 ProgressBar Helper. It allows for ETA output which is pretty nice and something we needed for a project. You might want to wait for the 2.5 Console Component to become stable before merging (If you want it!)