Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Symfony 2.5 ProgressBar Helper + allow option to set verbosity #73

Merged
merged 1 commit into from
Jun 2, 2014
Merged

Use Symfony 2.5 ProgressBar Helper + allow option to set verbosity #73

merged 1 commit into from
Jun 2, 2014

Conversation

AydinHassan
Copy link
Contributor

Hey, I've updated the ConsoleProgressWriter to use a new Symfony 2.5 ProgressBar Helper. It allows for ETA output which is pretty nice and something we needed for a project. You might want to wait for the 2.5 Console Component to become stable before merging (If you want it!)

@ddeboer
Copy link
Owner

ddeboer commented May 12, 2014

Hi, thanks! Yep, let's wait until 2.5 is stable. Alternatively, we could introduce your updated writer as a separate class, e.g., ConsoleProgressWriter25.

@AydinHassan
Copy link
Contributor Author

Would be nice to get it in so we don't have to maintain our own fork, so If you're cool with me providing a separate ConsoleProgressWriter25 i'll push that up 😄

@ddeboer
Copy link
Owner

ddeboer commented May 12, 2014

Yes!

"symfony/validator": "~2.3.0"
"symfony/console": "v2.5.0-BETA2",
"symfony/validator": "~2.3.0",
"phpunit/phpunit": "4.*"
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Noticed you added PHPUnit. Is this really necessary for the test to work?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No not really, My global version was complaining about something, so I just installed it locally. I'll remove it!

@AydinHassan
Copy link
Contributor Author

So which version of symfony/console should I put in the composer.json? Should I leave it as >=2.2 and put 2.5 as a suggest?

In fact, not sure this will work as we can't test on multiple versions - and it seems some of the other Console components have changed and the original ConsoleProgressWriter test is failing now with the 2.5 Component.

@ddeboer
Copy link
Owner

ddeboer commented May 13, 2014

Hmm, yes, that's unfortunate. Can we agree to leave this updated version out until 2.5 is stable and we can switch to that for require-dev?

@AydinHassan
Copy link
Contributor Author

Yeah no problem, I'll just use my fork for a bit :)

@AydinHassan AydinHassan mentioned this pull request Jun 1, 2014
@AydinHassan
Copy link
Contributor Author

Changed this to stable 2.5 and re-based. Should be good to merge now that 2.5 has gone stable. This will fix the tests also.

@ddeboer
Copy link
Owner

ddeboer commented Jun 2, 2014

Hmm, can you re-rebase? :)

@AydinHassan
Copy link
Contributor Author

Done :)

ddeboer added a commit that referenced this pull request Jun 2, 2014
Use Symfony 2.5 ProgressBar Helper + allow option to set verbosity
@ddeboer ddeboer merged commit 82697ee into ddeboer:master Jun 2, 2014
@ddeboer
Copy link
Owner

ddeboer commented Jun 2, 2014

Thanks!

@AydinHassan AydinHassan deleted the symfony-progressbar-helper branch June 2, 2014 14:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants