Make addon official

[seebeen]

Hello @rfay.

Can we make this addon official? All kinks and bugs ironed out.

[rfay]

Thanks for your work on this.

Just a casual look around... it doesn't seem like the tests run on several different situations. For example, the most recent commit didn't run tests, https://github.com/oblakstudio/ddev-minio/commits/master/ - Why is that? (I'm glad to see the daily tests will run now, but they haven't run automatically yet...)

Are you now subscribed to get notifications of test failures?

[rfay]

@tyler36 @stasadev would you mind doing a review of this add-on before it becomes official? Thanks!

[tyler36]

Not sure if there's configuration I'm missing, but my project doesn't start:

DDEV: v1.23.0
ddev-minio: v2.0.2

Test

1. Confirm DDEV project working

$ ddev start  
...
Project can be reached at https://30days-l11-demo.ddev.site https://127.0.0.1:52787 

1. Install addon

$ ddev get oblakstudio/ddev-minio
...
Installed minio:v2.0.2 from oblakstudio/ddev-minio 

1. Restart project

$ ddev restart
......Project images built in 6s. 
 Network ddev-30days-l11-demo_default  Created 
 Volume "ddev-30days-l11-demo-minio"  Created 
Error response from daemon: Range of CPUs is from 0.01 to 2.00, as there are only 2 CPUs available 

[rfay]

/cc @stasadev - I guess the 2.5 doesn't work for everybody.

[rfay]

@tyler36 you can probably fix this just by changing your docker cpu reservation to something higher than the default 2 I guess? I bet your machine has plenty of threads available.

[seebeen]

Running MinIO without any limits can cause it to takeover the entire CPU because it's both CPU and memory hungry. Capping it to below 2 CPUs will make it unusable. I'm assuming that anyone who uses docker has more than 2 CPU cores at their disposal.

[tyler36]

I'm using Docker Desktop and running DDEV in WSL2 currently.
DD says "You are using the WSL 2 backend, so resource limits are managed by Windows."

I have .wslconfig set limit CPU to 2:

[wsl2]
processors=2 # Makes the WSL 2 VM use two virtual processors

I guess I can play around with that later.

[stasadev]

I will review this add-on next week.

Error response from daemon: Range of CPUs is from 0.01 to 2.00, as there are only 2 CPUs available

Capping it to below 2 CPUs will make it unusable.

I guess the 2.5 doesn't work for everybody.

I checked and 1.99 can be used instead 🙂

[stasadev]

The add-on looks solid, and I agree with making it official.

@seebeen, I see ddev composer require aws/aws-sdk-php in the README.md, but there is no example of what to do after that.

What do you think about adding something like this to make things easier for beginners?

<?php

require __DIR__ . '/vendor/autoload.php';

$s3 = new \Aws\S3\S3Client([
    'endpoint' => 'http://minio:10101',
    'credentials' => [
        'key' => 'ddevminio',
        'secret' => 'ddevminio',
    ],
    'region' => 'us-east-1',
    'version' => 'latest',
    'use_path_style_endpoint' => true,
]);

$bucketName = 'ddev-minio';

if (!$s3->doesBucketExist($bucketName)) {
    $s3->createBucket([
        'Bucket' => $bucketName,
    ]);
}

$s3->putObject([
    'Bucket' => $bucketName,
    'Key' => 'ddev-test',
    'Body' => 'DDEV Minio is working!',
]);

$object = $s3->getObject([
    'Bucket' => $bucketName,
    'Key' => 'ddev-test',
]);

echo $object['Body'];

[stasadev]

These should be #ddev-generated, not # ddev-generated:

https://github.com/oblakstudio/ddev-minio/blob/3f7e76e3e7e017ab01f456e86ce8ddf876488e0e/.minioImageBuild/Dockerfile#L1

https://github.com/oblakstudio/ddev-minio/blob/3f7e76e3e7e017ab01f456e86ce8ddf876488e0e/.minioImageBuild/ddev-entrypoint.sh#L2

[rfay]

Thanks! @seebeen please make those fixes and let's move this to the ddev org. Or if you prefer, we can move it first, and then you can make those changes.

[rfay]

If you make @stasadev and @rfay admin on this repo, we can move it and then you'll have a variety of cleanup to do, thanks! You'll remain the primary maintainer.

[seebeen]

Added you both to the repo. Let's do this and I'll cleanup and improve immediately :)

[stasadev]

Done, sent invitation for @seebeen.

[stasadev]

@seebeen could you please create a new release?

Automatic release failed with token error and I'm not sure what token is needed here.

Note: there have been no releases since the add-on became official.

[stasadev]

@seebeen, a reminder that we need a new release 🙂

[github-actions]

🎉 This issue has been resolved in version 2.0.3 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

[rfay]

Yay!