Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump mongo-express, update config, do not expand php version, fixes #16 #18

Merged
merged 1 commit into from
Mar 28, 2024
Merged

Bump mongo-express, update config, do not expand php version, fixes #16 #18

merged 1 commit into from
Mar 28, 2024

Conversation

stasadev
Copy link
Member

The Issue

How This PR Solves The Issue

  • mongo-express has new v1 release
  • add HTTPS_EXPOSE
  • comment out MONGO_INITDB_DATABASE because it has no effect anyway
  • do not expand php${DDEV_PHP_VERSION}-mongodb to php8.2-mongodb

Manual Testing Instructions

ddev get ddev/ddev-mongo
ddev restart
# open mongo-express on 9092 port

Automated Testing Overview

Related Issue Link(s)

Release/Deployment Notes

@stasadev stasadev mentioned this pull request Mar 27, 2024
Closed
@rfay rfay requested a review from julienloizelet March 27, 2024 17:44
julienloizelet
julienloizelet approved these changes Mar 28, 2024
View reviewed changes
Copy link
Collaborator

@julienloizelet julienloizelet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works great. Thanks !

@julienloizelet julienloizelet merged commit e9b4a89 into main Mar 28, 2024
2 checks passed
@stasadev stasadev deleted the 20240327_stasadev_mongo_express branch March 28, 2024 09:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@julienloizelet julienloizelet julienloizelet approved these changes

Assignees
No one assigned
Labels
None yet
Projects
Next TODOs
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@stasadev @julienloizelet