Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: launch ddev phpmyadmin by port #14

Merged
merged 1 commit into from
Jul 6, 2024
Merged

refactor: launch ddev phpmyadmin by port #14

merged 1 commit into from
Jul 6, 2024

Conversation

stasadev
Copy link
Member

@stasadev stasadev commented Jun 10, 2024 •
edited
Loading

The Issue

Launch can be simpler with DDEV v1.23.0+

How This PR Solves The Issue

Refactors the code. Adds volumes from:

Manual Testing Instructions

ddev get https://github.com/ddev/ddev-phpmyadmin/tarball/20240611_stasadev_launch
ddev restart
ddev phpmyadmin

rfay
rfay approved these changes Jul 6, 2024
View reviewed changes
Copy link
Member

@rfay rfay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested, works perfectly, thanks!

@rfay rfay merged commit 4a9fd7c into main Jul 6, 2024
2 checks passed
@rfay rfay deleted the 20240611_stasadev_launch branch July 6, 2024 15:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rfay rfay rfay approved these changes

Assignees
No one assigned
Labels
None yet
Projects
Next TODOs
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@stasadev @rfay