Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: enable HTTPS support, fixes #27 #39

Merged
merged 1 commit into from
Jun 4, 2024

Conversation

stasadev
Copy link
Member

@stasadev stasadev commented Jun 4, 2024

The Issue

How This PR Solves The Issue

Enables X-Forwarded- headers in the Solr webserver (Jetty), making HTTP and HTTPS work.

I found the answer here https://serverfault.com/questions/618172/https-reverse-proxy-on-http-jetty

Manual Testing Instructions

mkdir solr-test && cd solr-test
ddev config --auto
git clone https://github.com/ddev/ddev-solr
cd ddev-solr && git checkout 20240604_stasadev_solr_enable_https && cd ..
ddev get ddev-solr
ddev start

# And finally test HTTP and HTTPS

# should open HTTP
ddev launch :8983

# should open HTTPS
ddev launch :8943

Automated Testing Overview

Related Issue Link(s)

Release/Deployment Notes

@mkalkbrenner mkalkbrenner merged commit 3f045ac into main Jun 4, 2024
2 checks passed
@stasadev stasadev deleted the 20240604_stasadev_solr_enable_https branch June 4, 2024 12:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants