Minor fixups including ddev-generated #5
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rfay
commented
Jun 21, 2023
| @@ -91,7 +91,7 @@ runs a single Solr node. | |||
| 1. Enable the `search_api_solr_admin` module. (This sub-module is included in Search API Solr >= 4.2.1) | |||
| 2. Create a search server using the Solr backend and select `Solr Cloud with Basic Auth` as connector: | |||
| * HTTP protocol: `http` | |||
| * Solr node: `ddev-<project>-solr` (Replace <project> by your project's name.) | |||
There was a problem hiding this comment.
The fully qualified name is not required any more.
rfay
commented
Jun 21, 2023
| @@ -21,14 +21,14 @@ | |||
| # - press the "Upload Configset" button. | |||
| # - set the number of shards to "1" and press "Upload" | |||
|
|
|||
| version: '3.6' | |||
There was a problem hiding this comment.
version is obsolete in docker-compose
rfay
commented
Jun 21, 2023
| @@ -21,14 +21,14 @@ | |||
| # - press the "Upload Configset" button. | |||
| # - set the number of shards to "1" and press "Upload" | |||
|
|
|||
| version: '3.6' | |||
| #ddev-generated | |||
There was a problem hiding this comment.
#ddev-generated allows ddev get to overwrite this.
rfay
commented
Jun 21, 2023
| services: | ||
| solr: | ||
| image: solr:8.11.2 | ||
| image: solr:8.11 |
There was a problem hiding this comment.
IMO using the moving version means less maintenance required by you.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is just some minor things I ran across