Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add more details for compatibility and performances #14

Merged
merged 2 commits into from
Aug 9, 2023
Merged

Add more details for compatibility and performances #14

merged 2 commits into from
Aug 9, 2023

Conversation

robertoperuzzo
Copy link
Collaborator

No description provided.

rfay
rfay reviewed Aug 2, 2023
View reviewed changes
Copy link
Member

@rfay rfay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@robertoperuzzo robertoperuzzo added the documentation Improvements or additions to documentation label Aug 5, 2023
@robertoperuzzo robertoperuzzo requested a review from rfay August 6, 2023 06:49
rfay
rfay reviewed Aug 6, 2023
View reviewed changes
Copy link
Member

@rfay rfay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This would be slightly better with an explanation of what the links are so people don't have to click through to find out what you mean, but now it has the links.

Maybe they'll have arm64 someday, or maybe we'll figure out a reliable way to use the amd64 with arm64. I'm pretty sure with tweaking that this could be made to work on macOS 13.4 Apple Silicon with the right settings on orbStack, Docker Desktop, and Colima. But just the right settings.

@robertoperuzzo
Copy link
Collaborator Author

This would be slightly better with an explanation of what the links are so people don't have to click through to find out what you mean, but now it has the links.

Maybe they'll have arm64 someday, or maybe we'll figure out a reliable way to use the amd64 with arm64. I'm pretty sure with tweaking that this could be made to work on macOS 13.4 Apple Silicon with the right settings on orbStack, Docker Desktop, and Colima. But just the right settings.

You're right. I added some details.
Thanks.

@rfay
Copy link
Member

rfay commented Aug 9, 2023

Thanks, don't forget to do a release when you have everything you want sorted.

I don't recommend automatic merging, I'll turn that off.

rfay
rfay approved these changes Aug 9, 2023
View reviewed changes
Copy link
Member

@rfay rfay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks.

@robertoperuzzo robertoperuzzo merged commit b41e2c9 into main Aug 9, 2023
@robertoperuzzo robertoperuzzo deleted the robertoperuzzopatch-2 branch August 9, 2023 19:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rfay rfay rfay approved these changes

Assignees
No one assigned
Labels
documentation Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@robertoperuzzo @rfay