Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mark NETMSGTYPE_CL_STARTINFO as MSGFLAG_FLUSH #6823

Merged
merged 1 commit into from
Jul 8, 2023

Conversation

Robyt3
Copy link
Member

@Robyt3 Robyt3 commented Jul 8, 2023

This makes the client connect to the server faster. It's especially noticeable on servers with a low ping.

Closes #6811.

Checklist

  • Tested the change ingame
  • Provided screenshots if it is a visual change
  • Tested in combination with possibly related configuration options
  • Written a unit test (especially base/) or added coverage to integration test
  • Considered possible null pointers and out of bounds array indexing
  • Changed no physics that affect existing maps
  • Tested the change with ASan+UBSan or valgrind's memcheck (optional)

This makes the client connect to the server faster. It's especially noticeable on servers with a low ping.

Closes ddnet#6811.
Copy link
Member

@def- def- left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bors r+

@bors
Copy link
Contributor

bors bot commented Jul 8, 2023

Build succeeded!

The publicly hosted instance of bors-ng is deprecated and will go away soon.

If you want to self-host your own instance, instructions are here.
For more help, visit the forum.

If you want to switch to GitHub's built-in merge queue, visit their help page.

@bors bors bot merged commit 4260d51 into ddnet:master Jul 8, 2023
@Robyt3 Robyt3 deleted the Client-StartInfo-Flush branch July 8, 2023 10:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Client answer to NETMSG_CON_READY is not marked as MSGFLAG_FLUSH
2 participants