Repository navigation
Should nil limit return Pagy::OPTIONS[:limit] when set in initializer? #922
littleforest
started this conversation in
Changes and Refactorings
Replies: 1 comment 7 replies
|
Note #781 refers to pagy < 43, so it's old stuff that should be ignored to avoid confusion.
Actually when NOT otherwise set anywhere. If you explicitly set it to nil (for example passing it to the |
7 replies
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Uh oh!
There was an error while loading. Please reload this page.
We are passing the
limitoption to the paginator to set the number of items to serve with each page (this value can be customized by the end user). We expected thenillimit on page load to return what we have set forPagy::OPTIONS[:limit], but instead it returnsDEFAULT[:limit], which is set to 20. Is this deliberate, or can this be changed to return the limit set in the initializer?It looks per Discussion #781 that a
nillimit did previously set what had been customized in the initializer?All reactions