Add Meilisearch finite pagination by default in the meilisearch extra #417
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@benkoshy Please, when the retype branch will be updated, could you update the retype doc with the doc changes in this PR. Thanks! |
|
@brunoocasali FYI: There is a meilisearch related question, asked months ago (#400) that you may want to address officially... |
brunoocasali
force-pushed
the
feature/meilisearch-finite-pagination
branch
from
c8f346b
to
bb32ce0
Compare
With this change it's possible to use Meilisearch's new pagination "finite pagination". This is a breaking change because there is no limit/offset anymore, but hits_per_page/page. Check it out https://docs.meilisearch.com/learn/advanced/pagination.html#implementation-2
brunoocasali
force-pushed
the
feature/meilisearch-finite-pagination
branch
from
bb32ce0
to
4b9e567
Compare
|
I tried locally with a simple rails app, and it seems to be working fine @ddnexus :) |
|
Thank you @brunoocasali ! |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @ddnexus, this is the implementation to v6, which will support the finite pagination of Meilisearch out of the box.
The
limitandoffsetparams should no longer be used in this context, so this will be the most significant breaking change.