This repository was archived by the owner on Apr 2, 2020. It is now read-only.
Update to GitHub API v3 #8
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If a token is passed as an option, create a client authenticated by the token, otherwise just create an unauthenticated client. An unauthenticated client can only access public repositories for the given username. Also renames incorrect :oauth_token option to :access_token
Initial move to Octokit in 1d42d21 didn’t paginate through results so a limited set of repositories was being returned.
Provides a wider range of backup capabilities, rather than only the specified user’s public repositories. 1. Client is unauthenticated Backs up the specified user’s public repositories. 2. Client is authenticated and the login matches the username option The user specified by the username option is the authenticated user so both public and private repositories are backed up. 3. Client is authenticated but does not match the username option Backs up the specified user’s public repositories. Private repositories are accessed by using the same username as the login of an authenticated client (see above). 4. Client is unauthenticated and the username is an organisation Backs up the specified organisations’s public repositories. 5. Client is authenticated and the username is an organisation Backs up the specified organisations’s public repositories and the private repositories that the authenticated user has access to.
While octokit supports HTTP Basic auth (username/password), github-backup never supported this. For now just remove support so that only OAuth tokens are acceptable.
Copies and slightly improves #read_gitconfig from octopi. Only tries to read the config if a token is not supplied on the command line. [1] https://github.com/fcoury/octopi/blob/master/lib/octopi.rb
|
Thank you! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #6
Highlights: