Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update to Swift 4 #83

Merged
merged 3 commits into from
Sep 5, 2017
Merged

Update to Swift 4 #83

merged 3 commits into from
Sep 5, 2017

Conversation

saagarjha
Copy link
Contributor

Just a minor tweaks to get it compile in Swift 4 due to changes made by SE-0154.

@saagarjha saagarjha mentioned this pull request Jul 11, 2017
Closed
@saagarjha
Copy link
Contributor Author

Hmm…it looks like the build is failing because swift build --clean was deprecated and removed. @dduan Would you like me to update DistributionTests?

@dduan
Copy link
Owner

dduan commented Jul 14, 2017

Hi @saagarjha thanks for the PR! Do you mind dropping the changes in Just.xcodeproj/xcshareddata/xcschemes/Just.xcscheme and Just.xcodeproj/project.pbxproj? We need to bump the language version number here.

@saagarjha
Copy link
Contributor Author

saagarjha commented Jul 16, 2017 •
edited
Loading

Oh, I didn't notice the xcconfig. Let me fix it.

EDIT: @dduan Should I drop all the changes, or just the ones pertaining to SWIFT_VERSION?

@dduan dduan changed the base branch from master to swift-4 September 5, 2017 05:13
@dduan dduan merged commit 150b3a7 into dduan:swift-4 Sep 5, 2017
@saagarjha
Copy link
Contributor Author

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@saagarjha @dduan