Render to triangles #74
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The last commit fixes the problem. TestThe output STL files are as expected:
|
|
@deadsy 🙂 I was wondering if we can merge this PR. It's a simple and straightforward fix. It would save me some hassle. Thanks. |
|
Yes - give me a few days. I'm travelling at the moment and don't have time
to immediately do it. -jasonh
…On Sun, Dec 10, 2023 at 9:50 PM Megidd ***@***.***> wrote:
@deadsy <https://github.com/deadsy> 🙂 I was wondering if we can merge
this PR. It's a simple and straightforward fix. It would save me some
hassle. Thanks.
—
Reply to this email directly, view it on GitHub
<#74 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAYKH2M3Y4UG5ZKEHD2BCETYIWHXVAVCNFSM6AAAAAA3XBT5UOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQNBYHEZDOOBTHE>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reproduce
This PR tries to reproduce and debug a problem. The problem is that
render.ToSTL()works fine. However,render.ToTriangles()is problematic. This problem is just introduced recently.