Introduce ParticleAccessor::set_properties() taking a Tensor. #12684
Conversation
|
@gassmoeller -- FYI. But there are no places in ASPECT where we use the |
| // A Tensor object is not an array, so we cannot just create an | ||
| // ArrayView object for it. Rather, copy the data into a true | ||
| // array and make the ArrayView from that. | ||
| double array[dim]; | ||
| for (unsigned int d = 0; d < dim; ++d) | ||
| array[d] = new_properties[d]; | ||
|
|
||
| set_properties(make_array_view(array)); |
There was a problem hiding this comment.
This is where I would like to do
| // A Tensor object is not an array, so we cannot just create an | |
| // ArrayView object for it. Rather, copy the data into a true | |
| // array and make the ArrayView from that. | |
| double array[dim]; | |
| for (unsigned int d = 0; d < dim; ++d) | |
| array[d] = new_properties[d]; | |
| set_properties(make_array_view(array)); | |
| set_properties(make_array_view(new_properties.to_array())); |
as mentioned in the issue.
In fact, if the ArrayView constructor is not explicit, we can even skip make_array_view().
There was a problem hiding this comment.
Come to think of it - if we do implement to_array() then we don't need this extra function at all, so we should just implement to_array() :)
There was a problem hiding this comment.
The constructor is not explicit:
template <std::size_t N>
ArrayView(value_type (&array)[N]);
I can't quite figure out from your comments where you are asking me to make changes?
There was a problem hiding this comment.
I'll put up a PR with what I want in it.
There was a problem hiding this comment.
How about we merge this now and then do what you suggest as a follow-up? It doesn't become easier/less work for anyone when we try to interleave patches from different people :-)
There was a problem hiding this comment.
I meant to respond to this, sorry!
Yes, lets just merge this as-is and I'll deal with what I would like to happen next in my own PR.
|
@bangerth can you rebase? |
bangerth
force-pushed
the
tensor-array-view
branch
from
dd9bde7
to
d65a586
Compare
|
Rebased. |
The resolution in #12624 was that we don't want to allow
ArrayViewpointing to aTensorobject. This removes one of two uses of this by providing a different overload when setting tensors as properties for particles./rebuild