Avoid the use of ArrayView for Tensors in MPI::sum(). #12685
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks, @masterleinad -- fixed! |
masterleinad
approved these changes
Aug 20, 2021
There was a problem hiding this comment.
Looks good to me but we should probably discuss @drwells proposal to add a Tensor::to_array member function that would avoid the boilerplate code here.
|
How about we merge this now and then do what you suggest as a follow-up? It doesn't become easier/less work for anyone when we try to interleave patches from different people :-) |
I agree, we should just not forget to come back to this place. |
kronbichler
approved these changes
Aug 23, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the second place where we use
ArrayViewforTensorobjects (the other one is fixed in #12684). As discussed in #12624, we want to avoid this./rebuild