Make Tensor::unroll() work with iterators. #12692
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bangerth
reviewed
Aug 21, 2021
|
Returning an array isn't going to work - MSVC cannot handle Instead I implemented a new version of |
drwells
changed the title
bangerth
reviewed
Aug 27, 2021
Do you mean rank > 0? That was already there - I added the rank = 0 version. I don't need it any more for this PR so I think I will drop the commit anyway. |
bangerth
approved these changes
Sep 7, 2021
|
OK with me. The naming is not important. /rebuild |
|
The CI check failed with an internal compiler error. I suspect it has nothing to do with your patch, but just to be on the safe side, could you rebase and push to start the check again? |
This makes the code applicable for more linear data structures than just Vector.
kronbichler
approved these changes
Sep 9, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Alternative to #12684 and #12685. Conflicts with #12685 and #12691.If we want to get rid of
make_array_view(Tensor)then we should offer a different way to convert theTensorinto a contiguous array.This PR adds a new functionThis PR addsTensor::to_array()that does exactly that so that we do not need to do it manually whenever the need arises.Tensor::unroll(begin, end)which populates some output structure with tensor values.A related change is thatTensorhas a constructor which takes anArrayViewas an argument, but we can only forward-declareArrayViewin that file due to the opposite-order dependency inarray_view.h(inmake_array_view(Tensor &)). I addressed that by moving themake_array_view()functions into the other headers.