Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pidgy lite kernel #67

Merged
merged 9 commits into from
Dec 14, 2021
Merged

Conversation

bollwyvl
Copy link
Contributor

@bollwyvl bollwyvl commented Dec 7, 2021

Changes

  • adds a pidgy lite kernel based on pyolite
  • uses environment.yml in docs build
  • syntax highlighting

Shots

Screenshot from 2021-12-07 09-24-03

Screenshot from 2021-12-07 09-20-21

dodo.py Outdated Show resolved Hide resolved
@@ -3,6 +3,9 @@
"output_dir": "./_/_",
"contents": [
"../docs"
],
"federated_extensions": [
"./jupyterlite-pidgy/dist/jupyterlite_pidgy-0.1.0-py3-none-any.whl"
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

since we're going with all extensions in sys.prefix, we can just do a dev install of this... will want for syntax highlighting anyway

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not dev installing yet... will do once syntax highlighting...

"strict": true,
"strictNullChecks": true,
"target": "es2019",
"types": [],
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

couldn't get lib working with WebWorker, ScriptHost, ...

@bollwyvl
Copy link
Contributor Author

bollwyvl commented Dec 7, 2021

So to confidently create the syntax highlighting mode (and/or jupyterlab-lsp transclusion sauce), i feel like a need a contract somewhere, preferably in something portable like json.

it's possible this could be interactive, e.g. in:

  • kernel_info
  • a display item...
    • allows for more features down the line, but an empty notebook wouldn't have anywhere to land this

@tonyfast
Copy link
Member

i love this so much. i'm gonna merge it in without highlighting so i can i start thinking about the docs.

its nice to remove some of the logic to get someone start in a pidgy notebook.

@tonyfast tonyfast merged commit 0162157 into deathbeds:main Dec 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants