Update #1
Merged
Update #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* fix(keybinding): Meta+ArrowDown respects disabled items * chore(keybinds): update test * revert id change * chore: update test * remove .only Co-authored-by: Paco <34928425+pacocoursey@users.noreply.github.com>
upgrade radix-ui/react-dialog
* arrow keys wrap around * make wraparound dependent on loop prop * document loop prop * prettier formatting
* Allow setting container to Radix Portal * add documentation for container prop * Add note explaining container prop * Replace `querySelector` in example with useRef * prettier formatting * fix up jsdoc Co-authored-by: Paco <34928425+pacocoursey@users.noreply.github.com>
* Update test.yml * Update playwright.config.ts * fix prettier
This commit removes a seemingly unnecessary React `<Fragment>` from the index page definition. In general, I think less code is better. :)
feat: export individual components
use pnpm/action-setup
* fix: keep item value controlled * test: add keep controlled value test --------- Co-authored-by: Paco <34928425+pacocoursey@users.noreply.github.com>
feat: use aria-activedescendant in input Co-authored-by: Paco <34928425+pacocoursey@users.noreply.github.com>
Co-authored-by: Paco <34928425+pacocoursey@users.noreply.github.com>
* fix: keep focus on the initial value * fix: prettier stuff * prettier --------- Co-authored-by: Paco <34928425+pacocoursey@users.noreply.github.com>
chore: use offsetHeight to calculate list height
* chore: add data-disabled to item * docs: use data-attributes in docs and examples
* feat: add default value prop * fix: revert example * fix: check for undefined toLowerCase * fix: prettier test format
* chore: use forceMount from group as fallback * fix: undefined forceMount * fix: check for null/undefined for group id * fix: add forceMount to deps Co-authored-by: Paco <34928425+pacocoursey@users.noreply.github.com> --------- Co-authored-by: Paco <34928425+pacocoursey@users.noreply.github.com>
* move command-score into local dep * remove command-score dep * add tests from #16 * update lockfile
* docs: add forceMount prop * Apply suggestions from code review --------- Co-authored-by: Paco <34928425+pacocoursey@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.