-
Notifications
You must be signed in to change notification settings - Fork 936
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
3.2.0 wrongly released as minor version #603
Comments
+1 |
this module is widely used in node community, it is hard to pin the version of debug in application's package.json. replace all |
UPDATE: Everything should be back to normal. Read the post-mortem for more information.Awkward. Side effect of going so long between releases is stuff like this is missed. Node 4 is out of LTS, and has been for a long while. It was last released in March of this year. The last non-LTS version was released in 2015. Please keep that in mind. Here's what I'll do:
Is that acceptable? UPDATE:Everything should be back to normal. Read the post-mortem for more information.
Post-mortem to come when it's determined the problems have been mitigated. I write some juicy[1] post-mortems[2] so stay tuned. |
@dead-horse That wouldn't work. There are a whole arsenal of things Node 4 doesn't support. |
#603 (comment) seems good. 👍 |
Complete solution 👍 |
👍 |
@mariodu @jtyjty99999 @dead-horse / anyone that's reading this: Can one of the afflicted confirm that it fixes Node 4 for you? |
Other problem is that with Still I'm not sure if any modules which explicitly relied on I was affected but only because I pointed v3 to deps which expected v2 but for which v3.1 was still safe to use (e.g. |
@medikoo what was
If it's absolutely necessary I can re-add and release EDIT: I see now. It was one of those things that shouldn't have happened in the first place. https://github.com/babel/babel/blob/eac4c5bc17133c2857f2c94c1a6a8643e3b547a7/.github/CHANGELOG-6to5.md#3015 - a patch to |
I'm not sure about intentions, but it was used here https://github.com/babel/babel/blob/v6.26.3/packages/babel-core/src/transformation/file/logger.js#L2
This module was publicly published, so removing it makes breaking change, no matter whether it was intentionally published or not |
Not necessarily - if it's not being used and it's not documented anywhere in the docs (nor does the source have any comments talking about what it's used for) then there was little chance in affecting the public API, hence no need to bump the major version. a31178c was the commit that introduced it. It was a hot-fix for a completely unrelated module. There was even concern at the time (a31178c#commitcomment-20264787) about how it was blatant technical debt. This is what happens when you introduce technical debt with no action-plan as to how to pay it back in the future - especially when you don't document it. I'll re-introduce |
Thank you! |
No problem. |
As I look, there's no |
@medikoo right you are. Here we go again. |
@Qix- you just accidentally deprecated the entire package on npm: |
If you deprecate the version which is tagged as |
You're being cached. You're looking at 3.2.4 which is correctly deprecated. Give it a few minutes and npm will show Not sure why npm is showing |
@Qix- npmjs has tagged Look at http://registry.npmjs.org/debug and https://www.npmjs.com/package/debug |
remove support for node.js v4 is a breaking change, should publish with major version.
The text was updated successfully, but these errors were encountered: