Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add Node.js 10, remove Node.js 4 #583

Merged
merged 1 commit into from Jun 24, 2018
Merged

chore: add Node.js 10, remove Node.js 4 #583

merged 1 commit into from Jun 24, 2018

Conversation

DanielRuf
Copy link
Contributor

@DanielRuf DanielRuf commented Jun 22, 2018

No description provided.

@coveralls
Copy link

@coveralls coveralls commented Jun 22, 2018

Coverage Status

Coverage increased (+1.2%) to 75.0% when pulling 663a088 on DanielRuf:chore/add-nodejs-10 into 02b9ea9 on visionmedia:master.

1 similar comment
@coveralls
Copy link

@coveralls coveralls commented Jun 22, 2018

Coverage Status

Coverage increased (+1.2%) to 75.0% when pulling 663a088 on DanielRuf:chore/add-nodejs-10 into 02b9ea9 on visionmedia:master.

@Qix- Qix- merged commit 05b0ceb into debug-js:master Jun 24, 2018
2 checks passed
@Qix-
Copy link
Member

@Qix- Qix- commented Jun 24, 2018

Thanks!

@DanielRuf DanielRuf deleted the chore/add-nodejs-10 branch Jun 24, 2018
@popomore
Copy link

@popomore popomore commented Sep 11, 2018

It should be a breaking change, why it is published as semver minor.

@Qix-
Copy link
Member

@Qix- Qix- commented Sep 11, 2018

@popomore how is this a breaking change?

Node 4 is out of LTS. Using Node 4 is deprecated.

Further, this PR doesn't affect the public API. Therefore it doesn't constitute a major bump.

@popomore
Copy link

@popomore popomore commented Sep 11, 2018

@qix the package or application use debug on Node 4 is broken after this version published.

@Qix-
Copy link
Member

@Qix- Qix- commented Sep 11, 2018

@popomore that's not our problem. Node 4 is out of LTS - this code is updated to use modern ES6 that should work on all LTS versions of Node. This PR isn't what changed that. The codebase already had some of it beforehand.

Pin your packages if you're worried about packages breaking because you're using Node versions outside of LTS. We can only delay moving forward for so long.

@dead-horse
Copy link

@dead-horse dead-horse commented Sep 11, 2018

ba8a424

this is a BREAKING change even node 4 is out of LTS, it breaks all programs which are still running on node 4 (maybe for some historical problem). Drop support for old version of node should be consider as a major version.

@debug-js debug-js locked as off-topic and limited conversation to collaborators Sep 11, 2018
@Qix-
Copy link
Member

@Qix- Qix- commented Sep 11, 2018

Let's move this out of this PR and into #603 please. No need to spam the OP here.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants