Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix nwjs support #569

Merged
merged 2 commits into from
Jul 26, 2018
Merged

Fix nwjs support #569

merged 2 commits into from
Jul 26, 2018

Conversation

miaulightouch
Copy link
Contributor

fix debug won't show message in nwjs

@coveralls
Copy link

coveralls commented May 11, 2018 •
edited
Loading

Coverage Status

Coverage increased (+1.2%) to 75.0% when pulling eed5722 on miaulightouch:master into 05b0ceb on visionmedia:master.

miaulightouch added a commit to LightouchDev/debug-es that referenced this pull request May 17, 2018
@miaulightouch
Refactoring codebase
28bdc0d 
close debug-js/debug#569
close debug-js/debug#563
@Qix-
Copy link
Member

Qix- commented Jun 20, 2018

I'm 👎 on this, seems like a very platform-specific check. An issue might need to be opened over at nwjs.

@Qix- Qix- added feature This proposes or provides a feature or enhancement change-patch This proposes or provides a change that requires a patch release awaiting-response This issue or pull request is awaiting a user's response discussion This issue is requesting comments and discussion and removed awaiting-response This issue or pull request is awaiting a user's response labels Jun 20, 2018
@miaulightouch
Copy link
Contributor Author

I don't get it.
if this is very platform-specific check, then window.process.type === 'renderer' should be removed and usage on Electron would be broken.

process.type is not presented in normal nodejs, it's only on Electron to show current process is renderer process or main process. so what's the issue for nwjs?

In the other hand, nwjs redirect all process.stdout, process.stderr to devtools, if let debug work like in nodejs, it would be very tricky.

@Qix-
Copy link
Member

Qix- commented Jul 26, 2018

Hey, you're right. Can you rebase?

@Qix- Qix- added the awaiting-response This issue or pull request is awaiting a user's response label Jul 26, 2018
@Qix- Qix- merged commit 207a6a2 into debug-js:master Jul 26, 2018
@Qix-
Copy link
Member

Qix- commented Jul 26, 2018

Thanks :)

@Qix- Qix- removed the awaiting-response This issue or pull request is awaiting a user's response label Jul 26, 2018
bors bot added a commit to IMA-WorldHealth/TaskList that referenced this pull request Sep 11, 2018
@bors @greenkeeper
Merge #6
9994aee 
6: Update debug to the latest version 🚀 r=jniles a=greenkeeper[bot]




## Version **4.0.0** of **debug** was just published.

<table>
  <tr>
    <th align=left>
      Dependency
    </th>
    <td>
      <a target=_blank href=https://github.com/visionmedia/debug>debug</a>
    </td>
  </tr>
  <tr>
      <th align=left>
       Current Version
      </th>
      <td>
        3.2.3
      </td>
    </tr>
  <tr>
    <th align=left>
      Type
    </th>
    <td>
      dependency
    </td>
  </tr>
</table>



The version **4.0.0** is **not covered** by your **current version range**.

If you don’t accept this pull request, your project will work just like it did before. However, you might be missing out on a bunch of new features, fixes and/or performance improvements from the dependency update.

It might be worth looking into these changes and trying to get this project onto the latest version of debug.

If you have a solid test suite and good coverage, a passing build is a strong indicator that you can take advantage of these changes directly by merging the proposed change into your project. If the build fails or you don’t have such unconditional trust in your tests, this branch is a great starting point for you to work on the update.


---


<details>
<summary>Release Notes</summary>
<strong>4.0.0</strong>

<p>A long-awaited release to <code>debug</code> is available now: <strong><code>4.0.0</code></strong>.</p>
<h4>Due to the delay in release and the number of changes made (including bumping dependencies in order to mitigate vulnerabilities), it is highly recommended maintainers update to the latest package version and <em>test thoroughly</em>.</h4>
<h4>This release drops support for Node 4.</h4>
<hr>
<h3>Major Changes</h3>
<ul>
<li>move to XO (closes <a class="issue-link js-issue-link" data-error-text="Failed to load issue title" data-id="197527010" data-permission-text="Issue title is private" data-url="debug-js/debug#397" href="https://urls.greenkeeper.io/visionmedia/debug/issues/397">#397</a>): <a class="commit-link" href="https://urls.greenkeeper.io/visionmedia/debug/commit/ba8a424d41e9dc6129e081ac3aa9715be6a45fbd"><tt>ba8a424</tt></a></li>
<li>add Node.js 10, remove Node.js 4 (<a class="issue-link js-issue-link" data-error-text="Failed to load issue title" data-id="335027326" data-permission-text="Issue title is private" data-url="debug-js/debug#583" href="https://urls.greenkeeper.io/visionmedia/debug/pull/583">#583</a>): <a class="commit-link" href="https://urls.greenkeeper.io/visionmedia/debug/commit/05b0ceb8856bc7b6bb0f2adc3de5cae3cea9c872"><tt>05b0ceb</tt></a></li>
</ul>
<h3>Minor Changes</h3>
<ul>
<li>bump vulnerable packages: <a class="commit-link" href="https://urls.greenkeeper.io/visionmedia/debug/commit/853853f9f588044d76df3daf1959ca56c5f341b7"><tt>853853f</tt></a></li>
<li>Fix nwjs support (<a class="issue-link js-issue-link" data-error-text="Failed to load issue title" data-id="322430406" data-permission-text="Issue title is private" data-url="debug-js/debug#569" href="https://urls.greenkeeper.io/visionmedia/debug/pull/569">#569</a>): <a class="commit-link" href="https://urls.greenkeeper.io/visionmedia/debug/commit/207a6a2d53507ec9dd57c94c46cc7d3dd272306d"><tt>207a6a2</tt></a></li>
<li>add instance extends feature (<a class="issue-link js-issue-link" data-error-text="Failed to load issue title" data-id="276280081" data-permission-text="Issue title is private" data-url="debug-js/debug#524" href="https://urls.greenkeeper.io/visionmedia/debug/pull/524">#524</a>): <a class="commit-link" href="https://urls.greenkeeper.io/visionmedia/debug/commit/e43e5fed177b8698674748063f4ed1aaba1d59c8"><tt>e43e5fe</tt></a></li>
<li>Add TVMLKit support (<a class="issue-link js-issue-link" data-error-text="Failed to load issue title" data-id="332115083" data-permission-text="Issue title is private" data-url="debug-js/debug#579" href="https://urls.greenkeeper.io/visionmedia/debug/pull/579">#579</a>): <a class="commit-link" href="https://urls.greenkeeper.io/visionmedia/debug/commit/02b9ea9fd7ec95c42de47da13b4b6bb8e50025d8"><tt>02b9ea9</tt></a></li>
</ul>
<h3>Patches</h3>
<ul>
<li>clean up builds: <a class="commit-link" href="https://urls.greenkeeper.io/visionmedia/debug/commit/3ca23316a470f6bc6e0d75d297179cfc19bbc763"><tt>3ca2331</tt></a></li>
<li>remove needless command aliases in makefile: <a class="commit-link" href="https://urls.greenkeeper.io/visionmedia/debug/commit/9f4f8f59ba745166b0c014a61c76de5e73d4841a"><tt>9f4f8f5</tt></a></li>
<li>no longer checking for BROWSER=1: <a class="commit-link" href="https://urls.greenkeeper.io/visionmedia/debug/commit/623c08ef73f8211278d5596c88041c65a2a58ee7"><tt>623c08e</tt></a></li>
<li>fix tests: <a class="commit-link" href="https://urls.greenkeeper.io/visionmedia/debug/commit/57cde56e43003f6b404d4b3d9d76b74aafaeeec8"><tt>57cde56</tt></a></li>
<li>clean up makefile: <a class="commit-link" href="https://urls.greenkeeper.io/visionmedia/debug/commit/62822f12668e8a0b1d1a4fd5a1c2fce1d8715da3"><tt>62822f1</tt></a></li>
<li>fix tests: <a class="commit-link" href="https://urls.greenkeeper.io/visionmedia/debug/commit/833b6f84c8f8dc5b6f13da38ab0ef8a8ff86c0c9"><tt>833b6f8</tt></a></li>
<li>add .editorconfig: <a class="commit-link" href="https://urls.greenkeeper.io/visionmedia/debug/commit/2d2509e26bf6df1e1954267e3b1a1cb83973fb09"><tt>2d2509e</tt></a></li>
<li>add yarn-error.log to .gitignore: <a class="commit-link" href="https://urls.greenkeeper.io/visionmedia/debug/commit/7e1d5d94f31b37b460fb8d88000ab7ed0be3597e"><tt>7e1d5d9</tt></a></li>
<li>Improve usability of Windows notes w/ examples for prompts &amp; npm script (<a class="issue-link js-issue-link" data-error-text="Failed to load issue title" data-id="330761681" data-permission-text="Issue title is private" data-url="debug-js/debug#577" href="https://urls.greenkeeper.io/visionmedia/debug/pull/577">#577</a>): <a class="commit-link" href="https://urls.greenkeeper.io/visionmedia/debug/commit/1ad1e4a79ff36981c1972bb4e61f93c7d4ade68d"><tt>1ad1e4a</tt></a></li>
<li>Drop usage of <code>chrome.storage</code> (or make the storage backend pluggable): <a class="commit-link" href="https://urls.greenkeeper.io/visionmedia/debug/commit/71d2aa77ff54c3c95a000bdead6b710b2a762c3f"><tt>71d2aa7</tt></a></li>
<li>Detect 'process' package: <a class="commit-link" href="https://urls.greenkeeper.io/visionmedia/debug/commit/225c66f7198d2995e8232f9486aa9e087dc2a469"><tt>225c66f</tt></a></li>
<li>Update ms to 2.1.1 (<a class="issue-link js-issue-link" data-error-text="Failed to load issue title" data-id="286601560" data-permission-text="Issue title is private" data-url="debug-js/debug#539" href="https://urls.greenkeeper.io/visionmedia/debug/pull/539">#539</a>): <a class="commit-link" href="https://urls.greenkeeper.io/visionmedia/debug/commit/22f993216dcdcee07eb0601ea71a917e4925a30a"><tt>22f9932</tt></a></li>
<li>Update .npmignore (<a class="issue-link js-issue-link" data-error-text="Failed to load issue title" data-id="278743467" data-permission-text="Issue title is private" data-url="debug-js/debug#527" href="https://urls.greenkeeper.io/visionmedia/debug/pull/527">#527</a>): <a class="commit-link" href="https://urls.greenkeeper.io/visionmedia/debug/commit/a5ca7a20860e78a4ea47f80770c09c0c663bae1e"><tt>a5ca7a2</tt></a></li>
<li>fix colors with <code>supports-color@5</code>: <a class="commit-link" href="https://urls.greenkeeper.io/visionmedia/debug/commit/285dfe10a5c06d4a86176b54bef2d7591eedaf40"><tt>285dfe1</tt></a></li>
<li>Document <code>enable()</code> (<a class="issue-link js-issue-link" data-error-text="Failed to load issue title" data-id="265202236" data-permission-text="Issue title is private" data-url="debug-js/debug#517" href="https://urls.greenkeeper.io/visionmedia/debug/pull/517">#517</a>): <a class="commit-link" href="https://urls.greenkeeper.io/visionmedia/debug/commit/ab5083f68a7e4c1ab474ff06cd5995d706abf143"><tt>ab5083f</tt></a></li>
<li>refactor to make the common code be a setup function (<a class="issue-link js-issue-link" data-error-text="Failed to load issue title" data-id="259824649" data-permission-text="Issue title is private" data-url="debug-js/debug#507" href="https://urls.greenkeeper.io/visionmedia/debug/pull/507">#507</a>): <a class="commit-link" href="https://urls.greenkeeper.io/visionmedia/debug/commit/71169065b5262f9858ac78cc0b688c84a438f290"><tt>7116906</tt></a></li>
<li>Simplify and improve: <a class="commit-link" href="https://urls.greenkeeper.io/visionmedia/debug/commit/da51af8314436ab532c151583f7fd52b2ebf2a3e"><tt>da51af8</tt></a></li>
<li>use babel-ified distributed source for browsers: <a class="commit-link" href="https://urls.greenkeeper.io/visionmedia/debug/commit/b3f8f8e683915ef4fae3a77cbcebc6c410e65a8c"><tt>b3f8f8e</tt></a></li>
</ul>
<h3>Credits</h3>
<p>Huge thanks to <a class="user-mention" data-hovercard-user-id="827205" data-octo-click="hovercard-link-click" data-octo-dimensions="link_type:self" href="https://urls.greenkeeper.io/DanielRuf">@DanielRuf</a>, <a class="user-mention" data-hovercard-user-id="12223584" data-octo-click="hovercard-link-click" data-octo-dimensions="link_type:self" href="https://urls.greenkeeper.io/EirikBirkeland">@EirikBirkeland</a>, <a class="user-mention" data-hovercard-user-id="4483057" data-octo-click="hovercard-link-click" data-octo-dimensions="link_type:self" href="https://urls.greenkeeper.io/KyleStay">@KyleStay</a>, <a class="user-mention" data-hovercard-user-id="885648" data-octo-click="hovercard-link-click" data-octo-dimensions="link_type:self" href="https://urls.greenkeeper.io/Qix-">@Qix-</a>, <a class="user-mention" data-hovercard-user-id="7466144" data-octo-click="hovercard-link-click" data-octo-dimensions="link_type:self" href="https://urls.greenkeeper.io/abenhamdine">@abenhamdine</a>, <a class="user-mention" data-hovercard-user-id="345102" data-octo-click="hovercard-link-click" data-octo-dimensions="link_type:self" href="https://urls.greenkeeper.io/alexey-pelykh">@alexey-pelykh</a>, <a class="user-mention" data-hovercard-user-id="2006839" data-octo-click="hovercard-link-click" data-octo-dimensions="link_type:self" href="https://urls.greenkeeper.io/DiegoRBaquero">@DiegoRBaquero</a>, <a class="user-mention" data-hovercard-user-id="340062" data-octo-click="hovercard-link-click" data-octo-dimensions="link_type:self" href="https://urls.greenkeeper.io/febbraro">@febbraro</a>, <a class="user-mention" data-hovercard-user-id="8408911" data-octo-click="hovercard-link-click" data-octo-dimensions="link_type:self" href="https://urls.greenkeeper.io/kwolfy">@kwolfy</a>, and <a class="user-mention" data-hovercard-user-id="71256" data-octo-click="hovercard-link-click" data-octo-dimensions="link_type:self" href="https://urls.greenkeeper.io/TooTallNate">@TooTallNate</a> for their help!</p>
</details>

<details>
<summary>Commits</summary>
<p>The new version differs by 1 commits ahead by 1, behind by 2.</p>
<ul>
<li><a href="https://urls.greenkeeper.io/visionmedia/debug/commit/7fb104b8cfcbc3a91d8e4a6727638c3fe24be8d2"><code>7fb104b</code></a> <code>4.0.0</code></li>
</ul>
<p>See the <a href="https://urls.greenkeeper.io/visionmedia/debug/compare/700a01074456ac42922392c7f327b2d7dfe23dc8...7fb104b8cfcbc3a91d8e4a6727638c3fe24be8d2">full diff</a></p>
</details>

<details>
  <summary>FAQ and help</summary>

  There is a collection of [frequently asked questions](https://greenkeeper.io/faq.html). If those don’t help, you can always [ask the humans behind Greenkeeper](https://github.com/greenkeeperio/greenkeeper/issues/new).
</details>

---


Your [Greenkeeper](https://greenkeeper.io) bot 🌴



Co-authored-by: greenkeeper[bot] <greenkeeper[bot]@users.noreply.github.com>
bors bot added a commit to Third-Culture-Software/bhima that referenced this pull request Sep 11, 2018
@bors @greenkeeper
Merge #3173
c94a1b4 
3173: Update debug to the latest version 🚀 r=jniles a=greenkeeper[bot]




## Version **4.0.0** of **debug** was just published.

<table>
  <tr>
    <th align=left>
      Dependency
    </th>
    <td>
      <a target=_blank href=https://github.com/visionmedia/debug>debug</a>
    </td>
  </tr>
  <tr>
      <th align=left>
       Current Version
      </th>
      <td>
        3.2.3
      </td>
    </tr>
  <tr>
    <th align=left>
      Type
    </th>
    <td>
      dependency
    </td>
  </tr>
</table>



The version **4.0.0** is **not covered** by your **current version range**.

If you don’t accept this pull request, your project will work just like it did before. However, you might be missing out on a bunch of new features, fixes and/or performance improvements from the dependency update.

It might be worth looking into these changes and trying to get this project onto the latest version of debug.

If you have a solid test suite and good coverage, a passing build is a strong indicator that you can take advantage of these changes directly by merging the proposed change into your project. If the build fails or you don’t have such unconditional trust in your tests, this branch is a great starting point for you to work on the update.


---


<details>
<summary>Release Notes</summary>
<strong>4.0.0</strong>

<p>A long-awaited release to <code>debug</code> is available now: <strong><code>4.0.0</code></strong>.</p>
<h4>Due to the delay in release and the number of changes made (including bumping dependencies in order to mitigate vulnerabilities), it is highly recommended maintainers update to the latest package version and <em>test thoroughly</em>.</h4>
<h4>This release drops support for Node 4.</h4>
<hr>
<h3>Major Changes</h3>
<ul>
<li>move to XO (closes <a class="issue-link js-issue-link" data-error-text="Failed to load issue title" data-id="197527010" data-permission-text="Issue title is private" data-url="debug-js/debug#397" href="https://urls.greenkeeper.io/visionmedia/debug/issues/397">#397</a>): <a class="commit-link" href="https://urls.greenkeeper.io/visionmedia/debug/commit/ba8a424d41e9dc6129e081ac3aa9715be6a45fbd"><tt>ba8a424</tt></a></li>
<li>add Node.js 10, remove Node.js 4 (<a class="issue-link js-issue-link" data-error-text="Failed to load issue title" data-id="335027326" data-permission-text="Issue title is private" data-url="debug-js/debug#583" href="https://urls.greenkeeper.io/visionmedia/debug/pull/583">#583</a>): <a class="commit-link" href="https://urls.greenkeeper.io/visionmedia/debug/commit/05b0ceb8856bc7b6bb0f2adc3de5cae3cea9c872"><tt>05b0ceb</tt></a></li>
</ul>
<h3>Minor Changes</h3>
<ul>
<li>bump vulnerable packages: <a class="commit-link" href="https://urls.greenkeeper.io/visionmedia/debug/commit/853853f9f588044d76df3daf1959ca56c5f341b7"><tt>853853f</tt></a></li>
<li>Fix nwjs support (<a class="issue-link js-issue-link" data-error-text="Failed to load issue title" data-id="322430406" data-permission-text="Issue title is private" data-url="debug-js/debug#569" href="https://urls.greenkeeper.io/visionmedia/debug/pull/569">#569</a>): <a class="commit-link" href="https://urls.greenkeeper.io/visionmedia/debug/commit/207a6a2d53507ec9dd57c94c46cc7d3dd272306d"><tt>207a6a2</tt></a></li>
<li>add instance extends feature (<a class="issue-link js-issue-link" data-error-text="Failed to load issue title" data-id="276280081" data-permission-text="Issue title is private" data-url="debug-js/debug#524" href="https://urls.greenkeeper.io/visionmedia/debug/pull/524">#524</a>): <a class="commit-link" href="https://urls.greenkeeper.io/visionmedia/debug/commit/e43e5fed177b8698674748063f4ed1aaba1d59c8"><tt>e43e5fe</tt></a></li>
<li>Add TVMLKit support (<a class="issue-link js-issue-link" data-error-text="Failed to load issue title" data-id="332115083" data-permission-text="Issue title is private" data-url="debug-js/debug#579" href="https://urls.greenkeeper.io/visionmedia/debug/pull/579">#579</a>): <a class="commit-link" href="https://urls.greenkeeper.io/visionmedia/debug/commit/02b9ea9fd7ec95c42de47da13b4b6bb8e50025d8"><tt>02b9ea9</tt></a></li>
</ul>
<h3>Patches</h3>
<ul>
<li>clean up builds: <a class="commit-link" href="https://urls.greenkeeper.io/visionmedia/debug/commit/3ca23316a470f6bc6e0d75d297179cfc19bbc763"><tt>3ca2331</tt></a></li>
<li>remove needless command aliases in makefile: <a class="commit-link" href="https://urls.greenkeeper.io/visionmedia/debug/commit/9f4f8f59ba745166b0c014a61c76de5e73d4841a"><tt>9f4f8f5</tt></a></li>
<li>no longer checking for BROWSER=1: <a class="commit-link" href="https://urls.greenkeeper.io/visionmedia/debug/commit/623c08ef73f8211278d5596c88041c65a2a58ee7"><tt>623c08e</tt></a></li>
<li>fix tests: <a class="commit-link" href="https://urls.greenkeeper.io/visionmedia/debug/commit/57cde56e43003f6b404d4b3d9d76b74aafaeeec8"><tt>57cde56</tt></a></li>
<li>clean up makefile: <a class="commit-link" href="https://urls.greenkeeper.io/visionmedia/debug/commit/62822f12668e8a0b1d1a4fd5a1c2fce1d8715da3"><tt>62822f1</tt></a></li>
<li>fix tests: <a class="commit-link" href="https://urls.greenkeeper.io/visionmedia/debug/commit/833b6f84c8f8dc5b6f13da38ab0ef8a8ff86c0c9"><tt>833b6f8</tt></a></li>
<li>add .editorconfig: <a class="commit-link" href="https://urls.greenkeeper.io/visionmedia/debug/commit/2d2509e26bf6df1e1954267e3b1a1cb83973fb09"><tt>2d2509e</tt></a></li>
<li>add yarn-error.log to .gitignore: <a class="commit-link" href="https://urls.greenkeeper.io/visionmedia/debug/commit/7e1d5d94f31b37b460fb8d88000ab7ed0be3597e"><tt>7e1d5d9</tt></a></li>
<li>Improve usability of Windows notes w/ examples for prompts &amp; npm script (<a class="issue-link js-issue-link" data-error-text="Failed to load issue title" data-id="330761681" data-permission-text="Issue title is private" data-url="debug-js/debug#577" href="https://urls.greenkeeper.io/visionmedia/debug/pull/577">#577</a>): <a class="commit-link" href="https://urls.greenkeeper.io/visionmedia/debug/commit/1ad1e4a79ff36981c1972bb4e61f93c7d4ade68d"><tt>1ad1e4a</tt></a></li>
<li>Drop usage of <code>chrome.storage</code> (or make the storage backend pluggable): <a class="commit-link" href="https://urls.greenkeeper.io/visionmedia/debug/commit/71d2aa77ff54c3c95a000bdead6b710b2a762c3f"><tt>71d2aa7</tt></a></li>
<li>Detect 'process' package: <a class="commit-link" href="https://urls.greenkeeper.io/visionmedia/debug/commit/225c66f7198d2995e8232f9486aa9e087dc2a469"><tt>225c66f</tt></a></li>
<li>Update ms to 2.1.1 (<a class="issue-link js-issue-link" data-error-text="Failed to load issue title" data-id="286601560" data-permission-text="Issue title is private" data-url="debug-js/debug#539" href="https://urls.greenkeeper.io/visionmedia/debug/pull/539">#539</a>): <a class="commit-link" href="https://urls.greenkeeper.io/visionmedia/debug/commit/22f993216dcdcee07eb0601ea71a917e4925a30a"><tt>22f9932</tt></a></li>
<li>Update .npmignore (<a class="issue-link js-issue-link" data-error-text="Failed to load issue title" data-id="278743467" data-permission-text="Issue title is private" data-url="debug-js/debug#527" href="https://urls.greenkeeper.io/visionmedia/debug/pull/527">#527</a>): <a class="commit-link" href="https://urls.greenkeeper.io/visionmedia/debug/commit/a5ca7a20860e78a4ea47f80770c09c0c663bae1e"><tt>a5ca7a2</tt></a></li>
<li>fix colors with <code>supports-color@5</code>: <a class="commit-link" href="https://urls.greenkeeper.io/visionmedia/debug/commit/285dfe10a5c06d4a86176b54bef2d7591eedaf40"><tt>285dfe1</tt></a></li>
<li>Document <code>enable()</code> (<a class="issue-link js-issue-link" data-error-text="Failed to load issue title" data-id="265202236" data-permission-text="Issue title is private" data-url="debug-js/debug#517" href="https://urls.greenkeeper.io/visionmedia/debug/pull/517">#517</a>): <a class="commit-link" href="https://urls.greenkeeper.io/visionmedia/debug/commit/ab5083f68a7e4c1ab474ff06cd5995d706abf143"><tt>ab5083f</tt></a></li>
<li>refactor to make the common code be a setup function (<a class="issue-link js-issue-link" data-error-text="Failed to load issue title" data-id="259824649" data-permission-text="Issue title is private" data-url="debug-js/debug#507" href="https://urls.greenkeeper.io/visionmedia/debug/pull/507">#507</a>): <a class="commit-link" href="https://urls.greenkeeper.io/visionmedia/debug/commit/71169065b5262f9858ac78cc0b688c84a438f290"><tt>7116906</tt></a></li>
<li>Simplify and improve: <a class="commit-link" href="https://urls.greenkeeper.io/visionmedia/debug/commit/da51af8314436ab532c151583f7fd52b2ebf2a3e"><tt>da51af8</tt></a></li>
<li>use babel-ified distributed source for browsers: <a class="commit-link" href="https://urls.greenkeeper.io/visionmedia/debug/commit/b3f8f8e683915ef4fae3a77cbcebc6c410e65a8c"><tt>b3f8f8e</tt></a></li>
</ul>
<h3>Credits</h3>
<p>Huge thanks to <a class="user-mention" data-hovercard-user-id="827205" data-octo-click="hovercard-link-click" data-octo-dimensions="link_type:self" href="https://urls.greenkeeper.io/DanielRuf">@DanielRuf</a>, <a class="user-mention" data-hovercard-user-id="12223584" data-octo-click="hovercard-link-click" data-octo-dimensions="link_type:self" href="https://urls.greenkeeper.io/EirikBirkeland">@EirikBirkeland</a>, <a class="user-mention" data-hovercard-user-id="4483057" data-octo-click="hovercard-link-click" data-octo-dimensions="link_type:self" href="https://urls.greenkeeper.io/KyleStay">@KyleStay</a>, <a class="user-mention" data-hovercard-user-id="885648" data-octo-click="hovercard-link-click" data-octo-dimensions="link_type:self" href="https://urls.greenkeeper.io/Qix-">@Qix-</a>, <a class="user-mention" data-hovercard-user-id="7466144" data-octo-click="hovercard-link-click" data-octo-dimensions="link_type:self" href="https://urls.greenkeeper.io/abenhamdine">@abenhamdine</a>, <a class="user-mention" data-hovercard-user-id="345102" data-octo-click="hovercard-link-click" data-octo-dimensions="link_type:self" href="https://urls.greenkeeper.io/alexey-pelykh">@alexey-pelykh</a>, <a class="user-mention" data-hovercard-user-id="2006839" data-octo-click="hovercard-link-click" data-octo-dimensions="link_type:self" href="https://urls.greenkeeper.io/DiegoRBaquero">@DiegoRBaquero</a>, <a class="user-mention" data-hovercard-user-id="340062" data-octo-click="hovercard-link-click" data-octo-dimensions="link_type:self" href="https://urls.greenkeeper.io/febbraro">@febbraro</a>, <a class="user-mention" data-hovercard-user-id="8408911" data-octo-click="hovercard-link-click" data-octo-dimensions="link_type:self" href="https://urls.greenkeeper.io/kwolfy">@kwolfy</a>, and <a class="user-mention" data-hovercard-user-id="71256" data-octo-click="hovercard-link-click" data-octo-dimensions="link_type:self" href="https://urls.greenkeeper.io/TooTallNate">@TooTallNate</a> for their help!</p>
</details>

<details>
<summary>Commits</summary>
<p>The new version differs by 1 commits ahead by 1, behind by 2.</p>
<ul>
<li><a href="https://urls.greenkeeper.io/visionmedia/debug/commit/7fb104b8cfcbc3a91d8e4a6727638c3fe24be8d2"><code>7fb104b</code></a> <code>4.0.0</code></li>
</ul>
<p>See the <a href="https://urls.greenkeeper.io/visionmedia/debug/compare/700a01074456ac42922392c7f327b2d7dfe23dc8...7fb104b8cfcbc3a91d8e4a6727638c3fe24be8d2">full diff</a></p>
</details>

<details>
  <summary>FAQ and help</summary>

  There is a collection of [frequently asked questions](https://greenkeeper.io/faq.html). If those don’t help, you can always [ask the humans behind Greenkeeper](https://github.com/greenkeeperio/greenkeeper/issues/new).
</details>

---


Your [Greenkeeper](https://greenkeeper.io) bot 🌴



Co-authored-by: greenkeeper[bot] <greenkeeper[bot]@users.noreply.github.com>
bors bot added a commit to IMA-WorldHealth/Tree that referenced this pull request Sep 12, 2018
@bors @greenkeeper
Merge #7
7ce35a7 
7: Update debug to the latest version 🚀 r=jniles a=greenkeeper[bot]




## Version **4.0.0** of **debug** was just published.

<table>
  <tr>
    <th align=left>
      Dependency
    </th>
    <td>
      <a target=_blank href=https://github.com/visionmedia/debug>debug</a>
    </td>
  </tr>
  <tr>
      <th align=left>
       Current Version
      </th>
      <td>
        3.2.3
      </td>
    </tr>
  <tr>
    <th align=left>
      Type
    </th>
    <td>
      dependency
    </td>
  </tr>
</table>



The version **4.0.0** is **not covered** by your **current version range**.

If you don’t accept this pull request, your project will work just like it did before. However, you might be missing out on a bunch of new features, fixes and/or performance improvements from the dependency update.

It might be worth looking into these changes and trying to get this project onto the latest version of debug.

If you have a solid test suite and good coverage, a passing build is a strong indicator that you can take advantage of these changes directly by merging the proposed change into your project. If the build fails or you don’t have such unconditional trust in your tests, this branch is a great starting point for you to work on the update.


---


<details>
<summary>Release Notes</summary>
<strong>4.0.0</strong>

<p>A long-awaited release to <code>debug</code> is available now: <strong><code>4.0.0</code></strong>.</p>
<h4>Due to the delay in release and the number of changes made (including bumping dependencies in order to mitigate vulnerabilities), it is highly recommended maintainers update to the latest package version and <em>test thoroughly</em>.</h4>
<h4>This release drops support for Node 4.</h4>
<hr>
<h3>Major Changes</h3>
<ul>
<li>move to XO (closes <a class="issue-link js-issue-link" data-error-text="Failed to load issue title" data-id="197527010" data-permission-text="Issue title is private" data-url="debug-js/debug#397" href="https://urls.greenkeeper.io/visionmedia/debug/issues/397">#397</a>): <a class="commit-link" href="https://urls.greenkeeper.io/visionmedia/debug/commit/ba8a424d41e9dc6129e081ac3aa9715be6a45fbd"><tt>ba8a424</tt></a></li>
<li>add Node.js 10, remove Node.js 4 (<a class="issue-link js-issue-link" data-error-text="Failed to load issue title" data-id="335027326" data-permission-text="Issue title is private" data-url="debug-js/debug#583" href="https://urls.greenkeeper.io/visionmedia/debug/pull/583">#583</a>): <a class="commit-link" href="https://urls.greenkeeper.io/visionmedia/debug/commit/05b0ceb8856bc7b6bb0f2adc3de5cae3cea9c872"><tt>05b0ceb</tt></a></li>
</ul>
<h3>Minor Changes</h3>
<ul>
<li>bump vulnerable packages: <a class="commit-link" href="https://urls.greenkeeper.io/visionmedia/debug/commit/853853f9f588044d76df3daf1959ca56c5f341b7"><tt>853853f</tt></a></li>
<li>Fix nwjs support (<a class="issue-link js-issue-link" data-error-text="Failed to load issue title" data-id="322430406" data-permission-text="Issue title is private" data-url="debug-js/debug#569" href="https://urls.greenkeeper.io/visionmedia/debug/pull/569">#569</a>): <a class="commit-link" href="https://urls.greenkeeper.io/visionmedia/debug/commit/207a6a2d53507ec9dd57c94c46cc7d3dd272306d"><tt>207a6a2</tt></a></li>
<li>add instance extends feature (<a class="issue-link js-issue-link" data-error-text="Failed to load issue title" data-id="276280081" data-permission-text="Issue title is private" data-url="debug-js/debug#524" href="https://urls.greenkeeper.io/visionmedia/debug/pull/524">#524</a>): <a class="commit-link" href="https://urls.greenkeeper.io/visionmedia/debug/commit/e43e5fed177b8698674748063f4ed1aaba1d59c8"><tt>e43e5fe</tt></a></li>
<li>Add TVMLKit support (<a class="issue-link js-issue-link" data-error-text="Failed to load issue title" data-id="332115083" data-permission-text="Issue title is private" data-url="debug-js/debug#579" href="https://urls.greenkeeper.io/visionmedia/debug/pull/579">#579</a>): <a class="commit-link" href="https://urls.greenkeeper.io/visionmedia/debug/commit/02b9ea9fd7ec95c42de47da13b4b6bb8e50025d8"><tt>02b9ea9</tt></a></li>
</ul>
<h3>Patches</h3>
<ul>
<li>clean up builds: <a class="commit-link" href="https://urls.greenkeeper.io/visionmedia/debug/commit/3ca23316a470f6bc6e0d75d297179cfc19bbc763"><tt>3ca2331</tt></a></li>
<li>remove needless command aliases in makefile: <a class="commit-link" href="https://urls.greenkeeper.io/visionmedia/debug/commit/9f4f8f59ba745166b0c014a61c76de5e73d4841a"><tt>9f4f8f5</tt></a></li>
<li>no longer checking for BROWSER=1: <a class="commit-link" href="https://urls.greenkeeper.io/visionmedia/debug/commit/623c08ef73f8211278d5596c88041c65a2a58ee7"><tt>623c08e</tt></a></li>
<li>fix tests: <a class="commit-link" href="https://urls.greenkeeper.io/visionmedia/debug/commit/57cde56e43003f6b404d4b3d9d76b74aafaeeec8"><tt>57cde56</tt></a></li>
<li>clean up makefile: <a class="commit-link" href="https://urls.greenkeeper.io/visionmedia/debug/commit/62822f12668e8a0b1d1a4fd5a1c2fce1d8715da3"><tt>62822f1</tt></a></li>
<li>fix tests: <a class="commit-link" href="https://urls.greenkeeper.io/visionmedia/debug/commit/833b6f84c8f8dc5b6f13da38ab0ef8a8ff86c0c9"><tt>833b6f8</tt></a></li>
<li>add .editorconfig: <a class="commit-link" href="https://urls.greenkeeper.io/visionmedia/debug/commit/2d2509e26bf6df1e1954267e3b1a1cb83973fb09"><tt>2d2509e</tt></a></li>
<li>add yarn-error.log to .gitignore: <a class="commit-link" href="https://urls.greenkeeper.io/visionmedia/debug/commit/7e1d5d94f31b37b460fb8d88000ab7ed0be3597e"><tt>7e1d5d9</tt></a></li>
<li>Improve usability of Windows notes w/ examples for prompts &amp; npm script (<a class="issue-link js-issue-link" data-error-text="Failed to load issue title" data-id="330761681" data-permission-text="Issue title is private" data-url="debug-js/debug#577" href="https://urls.greenkeeper.io/visionmedia/debug/pull/577">#577</a>): <a class="commit-link" href="https://urls.greenkeeper.io/visionmedia/debug/commit/1ad1e4a79ff36981c1972bb4e61f93c7d4ade68d"><tt>1ad1e4a</tt></a></li>
<li>Drop usage of <code>chrome.storage</code> (or make the storage backend pluggable): <a class="commit-link" href="https://urls.greenkeeper.io/visionmedia/debug/commit/71d2aa77ff54c3c95a000bdead6b710b2a762c3f"><tt>71d2aa7</tt></a></li>
<li>Detect 'process' package: <a class="commit-link" href="https://urls.greenkeeper.io/visionmedia/debug/commit/225c66f7198d2995e8232f9486aa9e087dc2a469"><tt>225c66f</tt></a></li>
<li>Update ms to 2.1.1 (<a class="issue-link js-issue-link" data-error-text="Failed to load issue title" data-id="286601560" data-permission-text="Issue title is private" data-url="debug-js/debug#539" href="https://urls.greenkeeper.io/visionmedia/debug/pull/539">#539</a>): <a class="commit-link" href="https://urls.greenkeeper.io/visionmedia/debug/commit/22f993216dcdcee07eb0601ea71a917e4925a30a"><tt>22f9932</tt></a></li>
<li>Update .npmignore (<a class="issue-link js-issue-link" data-error-text="Failed to load issue title" data-id="278743467" data-permission-text="Issue title is private" data-url="debug-js/debug#527" href="https://urls.greenkeeper.io/visionmedia/debug/pull/527">#527</a>): <a class="commit-link" href="https://urls.greenkeeper.io/visionmedia/debug/commit/a5ca7a20860e78a4ea47f80770c09c0c663bae1e"><tt>a5ca7a2</tt></a></li>
<li>fix colors with <code>supports-color@5</code>: <a class="commit-link" href="https://urls.greenkeeper.io/visionmedia/debug/commit/285dfe10a5c06d4a86176b54bef2d7591eedaf40"><tt>285dfe1</tt></a></li>
<li>Document <code>enable()</code> (<a class="issue-link js-issue-link" data-error-text="Failed to load issue title" data-id="265202236" data-permission-text="Issue title is private" data-url="debug-js/debug#517" href="https://urls.greenkeeper.io/visionmedia/debug/pull/517">#517</a>): <a class="commit-link" href="https://urls.greenkeeper.io/visionmedia/debug/commit/ab5083f68a7e4c1ab474ff06cd5995d706abf143"><tt>ab5083f</tt></a></li>
<li>refactor to make the common code be a setup function (<a class="issue-link js-issue-link" data-error-text="Failed to load issue title" data-id="259824649" data-permission-text="Issue title is private" data-url="debug-js/debug#507" href="https://urls.greenkeeper.io/visionmedia/debug/pull/507">#507</a>): <a class="commit-link" href="https://urls.greenkeeper.io/visionmedia/debug/commit/71169065b5262f9858ac78cc0b688c84a438f290"><tt>7116906</tt></a></li>
<li>Simplify and improve: <a class="commit-link" href="https://urls.greenkeeper.io/visionmedia/debug/commit/da51af8314436ab532c151583f7fd52b2ebf2a3e"><tt>da51af8</tt></a></li>
<li>use babel-ified distributed source for browsers: <a class="commit-link" href="https://urls.greenkeeper.io/visionmedia/debug/commit/b3f8f8e683915ef4fae3a77cbcebc6c410e65a8c"><tt>b3f8f8e</tt></a></li>
</ul>
<h3>Credits</h3>
<p>Huge thanks to <a class="user-mention" data-hovercard-user-id="827205" data-octo-click="hovercard-link-click" data-octo-dimensions="link_type:self" href="https://urls.greenkeeper.io/DanielRuf">@DanielRuf</a>, <a class="user-mention" data-hovercard-user-id="12223584" data-octo-click="hovercard-link-click" data-octo-dimensions="link_type:self" href="https://urls.greenkeeper.io/EirikBirkeland">@EirikBirkeland</a>, <a class="user-mention" data-hovercard-user-id="4483057" data-octo-click="hovercard-link-click" data-octo-dimensions="link_type:self" href="https://urls.greenkeeper.io/KyleStay">@KyleStay</a>, <a class="user-mention" data-hovercard-user-id="885648" data-octo-click="hovercard-link-click" data-octo-dimensions="link_type:self" href="https://urls.greenkeeper.io/Qix-">@Qix-</a>, <a class="user-mention" data-hovercard-user-id="7466144" data-octo-click="hovercard-link-click" data-octo-dimensions="link_type:self" href="https://urls.greenkeeper.io/abenhamdine">@abenhamdine</a>, <a class="user-mention" data-hovercard-user-id="345102" data-octo-click="hovercard-link-click" data-octo-dimensions="link_type:self" href="https://urls.greenkeeper.io/alexey-pelykh">@alexey-pelykh</a>, <a class="user-mention" data-hovercard-user-id="2006839" data-octo-click="hovercard-link-click" data-octo-dimensions="link_type:self" href="https://urls.greenkeeper.io/DiegoRBaquero">@DiegoRBaquero</a>, <a class="user-mention" data-hovercard-user-id="340062" data-octo-click="hovercard-link-click" data-octo-dimensions="link_type:self" href="https://urls.greenkeeper.io/febbraro">@febbraro</a>, <a class="user-mention" data-hovercard-user-id="8408911" data-octo-click="hovercard-link-click" data-octo-dimensions="link_type:self" href="https://urls.greenkeeper.io/kwolfy">@kwolfy</a>, and <a class="user-mention" data-hovercard-user-id="71256" data-octo-click="hovercard-link-click" data-octo-dimensions="link_type:self" href="https://urls.greenkeeper.io/TooTallNate">@TooTallNate</a> for their help!</p>
</details>

<details>
<summary>Commits</summary>
<p>The new version differs by 1 commits ahead by 1, behind by 2.</p>
<ul>
<li><a href="https://urls.greenkeeper.io/visionmedia/debug/commit/7fb104b8cfcbc3a91d8e4a6727638c3fe24be8d2"><code>7fb104b</code></a> <code>4.0.0</code></li>
</ul>
<p>See the <a href="https://urls.greenkeeper.io/visionmedia/debug/compare/700a01074456ac42922392c7f327b2d7dfe23dc8...7fb104b8cfcbc3a91d8e4a6727638c3fe24be8d2">full diff</a></p>
</details>

<details>
  <summary>FAQ and help</summary>

  There is a collection of [frequently asked questions](https://greenkeeper.io/faq.html). If those don’t help, you can always [ask the humans behind Greenkeeper](https://github.com/greenkeeperio/greenkeeper/issues/new).
</details>

---


Your [Greenkeeper](https://greenkeeper.io) bot 🌴



Co-authored-by: greenkeeper[bot] <greenkeeper[bot]@users.noreply.github.com>
This was referenced Oct 17, 2019
Open
Open
Open
Open
Open
Open
Open
Open
This was referenced Oct 26, 2019
Open
Open
Open
This was referenced Oct 26, 2019
Open
Open
Open
Open
Open
Open
Open
This was referenced Nov 11, 2019
Open
Merged
@snyk-bot snyk-bot mentioned this pull request Nov 25, 2019
Open
@snyk-bot snyk-bot mentioned this pull request Mar 8, 2020
Open
@snyk-bot snyk-bot mentioned this pull request Mar 21, 2020
Closed
miaulightouch added a commit to LightouchDev/debug-es that referenced this pull request Jun 29, 2020
@miaulightouch
Refactoring codebase
96bae67 
close debug-js/debug#569
close debug-js/debug#563
@snyk-bot snyk-bot mentioned this pull request Jul 17, 2021
Open
@snyk-bot snyk-bot mentioned this pull request Jun 1, 2022
Open
@snyk-bot snyk-bot mentioned this pull request Jun 22, 2022
Open
@LadyK-21 LadyK-21 mentioned this pull request Oct 6, 2022
Open
@ryan-ally ryan-ally mentioned this pull request Nov 27, 2023
Open
This was referenced Nov 28, 2023
Open
Open
@ryan-ally ryan-ally mentioned this pull request May 22, 2024
Open
@LadyK-21 LadyK-21 mentioned this pull request May 23, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
change-patch This proposes or provides a change that requires a patch release discussion This issue is requesting comments and discussion feature This proposes or provides a feature or enhancement
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@miaulightouch @coveralls @Qix-