Skip to content

Add unit tests covering some of IV8ScriptableObject #10

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Feb 4, 2025
Merged

Add unit tests covering some of IV8ScriptableObject #10

merged 2 commits into from
Feb 4, 2025

Conversation

AnsisMalins
Copy link
Collaborator

This change adds some unit tests. More to come.

pravusjif
pravusjif approved these changes Feb 4, 2025
View reviewed changes
Copy link
Member

@pravusjif pravusjif left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks pretty good to me, nice job!

For future tests you can use other Asserts like .IsNotNull(), IsTrue() etc. but not needed in this case.

mikhail-dcl
mikhail-dcl reviewed Feb 4, 2025
View reviewed changes
@AnsisMalins AnsisMalins merged commit 5a1a562 into master Feb 4, 2025
@AnsisMalins AnsisMalins deleted the chore/unit-tests-iv8scriptableobject branch February 4, 2025 18:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mikhail-dcl mikhail-dcl mikhail-dcl left review comments

@pravusjif pravusjif pravusjif approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@AnsisMalins @pravusjif @mikhail-dcl