Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add lists page #1747

Merged
merged 18 commits into from
Jun 1, 2023
Merged

feat: Add lists page #1747

merged 18 commits into from
Jun 1, 2023

Conversation

LautaroPetaccio
Copy link
Contributor

@LautaroPetaccio LautaroPetaccio commented May 31, 2023

This PR does the following:

  • Renames the ListsPage component into ListPage
  • Implements the ListsPage component, using the pagination hook.
  • Adds the lists route to the Routes component.
  • Sets the bases of a ListsPage that will contain the ListCard component and operate as a paginated component.

Closes #1718

@coveralls
Copy link

coveralls commented May 31, 2023

Coverage Status

coverage: 35.146% (+0.3%) from 34.836% when pulling 649b279 on feat/lists-page into 644a3fc on master.

import { Props } from './ProtectedRoute.types'

const ProtectedRoute = (props: Props) => {
const { isConnecting, wallet, ...rest } = props
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

WDYT about taking these props (isConnecting & wallet) from a custom container called ProtectedRoute.container.ts?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure I understand the question because the container is above this file. Can you show me an example?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, I meant having a ProtectedRoute.container.ts like this:

const mapState = (state: RootState): MapStateProps =>
  ({
    wallet: getWallet(state),
    isConnecting: isConnecting(state),
  });

Copy link
Contributor

@kevinszuchet kevinszuchet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Print it 🖨️

@LautaroPetaccio LautaroPetaccio merged commit 177085e into master Jun 1, 2023
@LautaroPetaccio LautaroPetaccio deleted the feat/lists-page branch June 1, 2023 13:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create the Lists Page
3 participants