feat: use squid to calculate route between two chains and tokens #2042
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
juanmahidalgo
force-pushed
the
feat/squid-integration
branch
from
befe907
to
58a6d82
Compare
juanmahidalgo
force-pushed
the
feat/squid-integration
branch
from
6b0abab
to
dda8743
Compare
juanmahidalgo
commented
Nov 23, 2023
webapp/src/config/env/dev.json
Outdated
| "BASE_NAME": "/marketplace", | ||
| "NFT_SERVER_URL": "https://nft-api.decentraland.zone/v1", | ||
| "MARKETPLACE_SERVER_URL": "https://marketplace-api.decentraland.zone/v1", | ||
| "NETWORK": "mainnet", |
There was a problem hiding this comment.
this will be rollbacked, just for testing purposes and to not have to add the env query string to each path to override the env.
cyaiox
reviewed
Nov 23, 2023
| "select_token": "Selecciona una moneda", | ||
| "no_matches": "No hay coincidencias para {search}..." | ||
| }, | ||
| "price_too_low": "Las transacciones de MANA solo están libres de tarifa de gas si el artículo tiene al menos 1 MANA. Para obtener este artículo, cambia tu red a Polygon para pagar la tarifa del gas con MATIC. {learn_more}", |
There was a problem hiding this comment.
Suggested change
| "price_too_low": "Las transacciones de MANA solo están libres de tarifa de gas si el artículo tiene al menos 1 MANA. Para obtener este artículo, cambia tu red a Polygon para pagar la tarifa del gas con MATIC. {learn_more}", | |
| "price_too_low": "Las transacciones de MANA solo están libres de tarifa de gas si el artículo cuesta al menos 1 MANA. Para obtener este artículo, cambia tu red a Polygon para pagar la tarifa del gas con MATIC. {learn_more}", |
cyaiox
reviewed
Nov 23, 2023
| "no_matches": "No hay coincidencias para {search}..." | ||
| }, | ||
| "price_too_low": "Las transacciones de MANA solo están libres de tarifa de gas si el artículo tiene al menos 1 MANA. Para obtener este artículo, cambia tu red a Polygon para pagar la tarifa del gas con MATIC. {learn_more}", | ||
| "remember_transaction_fee_covered": "Pague con Polygon MANA para que el DAO cubra las tarifas de gas (el artículo debe tener al menos 1 MANA).", |
There was a problem hiding this comment.
Suggested change
| "remember_transaction_fee_covered": "Pague con Polygon MANA para que el DAO cubra las tarifas de gas (el artículo debe tener al menos 1 MANA).", | |
| "remember_transaction_fee_covered": "Pague con Polygon MANA para que el DAO cubra las tarifas de gas (el artículo debe costar al menos 1 MANA).", |
cyaiox
reviewed
Nov 23, 2023
webapp/config-overrides.js
Outdated
| ] | ||
| config.moduleNameMapper = { | ||
| '@dcl/single-sign-on-client': 'identity-obj-proxy', | ||
| '^react-native$': 'react-native-web', |
There was a problem hiding this comment.
is it required react-native by @0xsquid?
There was a problem hiding this comment.
no but it's the default value that cra has, so that's why I added.
Instead of doing that, I just updated the logic to spread the default values and andd the one I need (@dcl/single-sign-on-client)
cyaiox
reviewed
Nov 23, 2023
webapp/src/modules/item/sagas.ts
Outdated
| ) | ||
| } | ||
| } catch (error) { | ||
| console.log('error: ', error) |
cyaiox
reviewed
Nov 23, 2023
| ? order.price | ||
| : !isNFT(asset) && +asset.price > 0 | ||
| ? asset.price | ||
| : 1 //TODO: review this |
There was a problem hiding this comment.
should we raise an error/alert if there's no price for the asset?
juanmahidalgo
force-pushed
the
feat/squid-integration
branch
from
59b7ead
to
46ade25
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WIP