feat: Use vite to build site #2105
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LautaroPetaccio
commented
Jan 19, 2024
| @@ -20,13 +20,6 @@ export * from './BidService' | |||
| export * from './ContractService' | |||
There was a problem hiding this comment.
I'm removing the services export as we're not longer using the vendors idea and we have a cyclic dependency later when instantiating them.
cyaiox
reviewed
Jan 19, 2024
| @@ -208,7 +208,9 @@ export const getIsMarketplaceServerEnabled = (state: RootState) => { | |||
| } | |||
|
|
|||
| export const getIsBuyCrossChainEnabled = (state: RootState) => { | |||
| if (hasLoadedInitialFlags(state)) { | |||
| const hasLoadedInitialFlagsx = hasLoadedInitialFlags(state) | |||
| console.log('Has loaded initial feature flags?', hasLoadedInitialFlagsx) | |||
There was a problem hiding this comment.
Looool, good catch, removed it.
cyaiox
reviewed
Jan 19, 2024
webapp/src/index.tsx
Outdated
| import { ConnectedRouter } from 'connected-react-router' | ||
| import * as SingleSignOn from '@dcl/single-sign-on-client' | ||
| import WalletProvider from 'decentraland-dapps/dist/providers/WalletProvider' | ||
| import ToastProvider from 'decentraland-dapps/dist/providers/ToastProvider' | ||
| import TranslationProvider from 'decentraland-dapps/dist/providers/TranslationProvider' | ||
| import ModalProvider from 'decentraland-dapps/dist/providers/ModalProvider' | ||
|
|
||
| import './setup' | ||
| // import './setup' |
There was a problem hiding this comment.
Suggested change
| // import './setup' |
cyaiox
approved these changes
Jan 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes the way we're building the Marketplace to use Vite.