Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Exceptions migrate to Result<> #1897

Merged
merged 9 commits into from
Aug 30, 2024
Merged

fix: Exceptions migrate to Result<> #1897

merged 9 commits into from
Aug 30, 2024

Conversation

NickKhalow
Copy link
Contributor

What does this PR change?

Exceptions are replaced to Result<> type in the flow, to avoid ambiguousity

Affects on: #1713 and #1129

...

How to test the changes?

  1. Launch the explorer
  2. Play happy path, ensure multiplayer is ok

Our Code Review Standards

https://github.com/decentraland/unity-renderer/blob/master/docs/code-review-standards.md

@NickKhalow NickKhalow self-assigned this Aug 27, 2024
@NickKhalow NickKhalow linked an issue Aug 27, 2024 that may be closed by this pull request
System.Exception: Cannot listen for connection string #1713
Closed
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Aug 27, 2024 •
edited
Loading

badge

Windows and Mac build successfull in Unity Cloud! You can find a link to the downloadable artifact below.

Name Link
Commit adb4122
Logs https://github.com/decentraland/unity-explorer/actions/runs/10614570279
Download Windows https://github.com/decentraland/unity-explorer/suites/27749834346/artifacts/1869727193
Download Mac https://github.com/decentraland/unity-explorer/suites/27749834346/artifacts/1869736688
Built on 2024-08-29T12:40:48Z

@NickKhalow NickKhalow enabled auto-merge (squash) August 29, 2024 13:00
@Ludmilafantaniella Ludmilafantaniella self-requested a review August 29, 2024 14:38
Ludmilafantaniella
Ludmilafantaniella approved these changes Aug 29, 2024
View reviewed changes
Copy link

@Ludmilafantaniella Ludmilafantaniella left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved. Tested the happy path, and multiplayer is working as expected. 🟢

@NickKhalow NickKhalow merged commit 377bffc into main Aug 30, 2024
5 checks passed
@NickKhalow NickKhalow deleted the fix/1713-websocket branch August 30, 2024 10:43
@NickKhalow NickKhalow mentioned this pull request Sep 2, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mikhail-dcl mikhail-dcl mikhail-dcl approved these changes

@Ludmilafantaniella Ludmilafantaniella Ludmilafantaniella approved these changes

@anicalbano anicalbano Awaiting requested review from anicalbano

@davidejensen davidejensen Awaiting requested review from davidejensen

Assignees

@NickKhalow NickKhalow

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

System.Exception: Cannot listen for connection string
3 participants
@NickKhalow @mikhail-dcl @Ludmilafantaniella