Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Redesign: read more literal #11516

Merged
merged 1 commit into from
Aug 29, 2023
Merged

Redesign: read more literal #11516

merged 1 commit into from
Aug 29, 2023

Conversation

Crashillo
Copy link
Member

🎩 What? Why?

Use a more accurate literal for the read more component

  • A dynamic link named "Close" on the process page when the process description is expanded. Close what? Maybe "Show less" would be more appropriate term here (COGA 3.1.1)

📷 Screenshots

https://decidim-redesign.populate.tools/processes/Decidim4Dummies

♥️ Thank you!

@Crashillo Crashillo added the contract: redesign Barcelona City Council contract label Aug 23, 2023
@Crashillo Crashillo requested a review from a team August 23, 2023 12:59
@andreslucena andreslucena added this to the 0.28.0 milestone Aug 23, 2023
Copy link
Contributor

@alecslupu alecslupu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@alecslupu alecslupu merged commit c19b73c into develop Aug 29, 2023
93 checks passed
@alecslupu alecslupu deleted the fix/a11y-readmore-literal branch August 29, 2023 00:03
entantoencuanto added a commit that referenced this pull request Aug 30, 2023
* develop:
  Add recognition to BrowserStack in the README (#11546)
  Remove unused view hook for `:upcoming_meeting_for_card` (#11543)
  Remove unused dependency: `wicked` (#11150)
  Clean-up initiatives signature URLs and methods (#11545)
  Refactor initiative signing wizard (#10731)
  Fix Permissions screen on budgets throw errors (#11532)
  Redesign: read more literal (#11516)
  Fix 'download your data' when there are comments on budgets (#11531)
entantoencuanto added a commit that referenced this pull request Sep 8, 2023
…gn-staging

* fix/activities-block-follow-button: (27 commits)
  Add tests to follow button in processes and assemblies landing page
  Add follow button to participatory spaces last activities content block
  Remove duplication from participatory spaces publications controllers (#11549)
  Fix the a11y tool icons with redesign (#11175)
  Remove duplication from amendments events specs (#11553)
  Remove duplication from elections' user roles forms (#11548)
  Update Node.js from v16.13.0 to v18.17.1 (#11564)
  Remove duplication from stats presenters (#11551)
  Fix Bootsnap configuration (#11483)
  Remove duplication for add questions specs examples (#11559)
  Remove duplication from invites queries (#11552)
  Fix typos and copy-paste errors from comments and examples (#11536)
  Fix conference venues meetings visibility (#11542)
  Add recognition to BrowserStack in the README (#11546)
  Remove unused view hook for `:upcoming_meeting_for_card` (#11543)
  Remove unused dependency: `wicked` (#11150)
  Clean-up initiatives signature URLs and methods (#11545)
  Refactor initiative signing wizard (#10731)
  Fix Permissions screen on budgets throw errors (#11532)
  Redesign: read more literal (#11516)
  ...
@andreslucena andreslucena added the type: feature PRs or issues that implement a new feature label Nov 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contract: redesign Barcelona City Council contract type: feature PRs or issues that implement a new feature
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

None yet

3 participants