-
-
Notifications
You must be signed in to change notification settings - Fork 392
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove duplication from invites queries #11552
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
By reading the code, i can see this PR only renames the Decidim::Meetings::Admin::Invites
to Decidim::Admin::Invites
, yet there is no change on the conference module, to highlight the featured changes.
Fetching the branch, Decidim::Conferences::Admin::ConferenceInvites
is still present.
Suggested on code review
I've missed that one. Is done at bf9dea4 This is ready to another review @alecslupu |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
…gn-staging * fix/activities-block-follow-button: (27 commits) Add tests to follow button in processes and assemblies landing page Add follow button to participatory spaces last activities content block Remove duplication from participatory spaces publications controllers (#11549) Fix the a11y tool icons with redesign (#11175) Remove duplication from amendments events specs (#11553) Remove duplication from elections' user roles forms (#11548) Update Node.js from v16.13.0 to v18.17.1 (#11564) Remove duplication from stats presenters (#11551) Fix Bootsnap configuration (#11483) Remove duplication for add questions specs examples (#11559) Remove duplication from invites queries (#11552) Fix typos and copy-paste errors from comments and examples (#11536) Fix conference venues meetings visibility (#11542) Add recognition to BrowserStack in the README (#11546) Remove unused view hook for `:upcoming_meeting_for_card` (#11543) Remove unused dependency: `wicked` (#11150) Clean-up initiatives signature URLs and methods (#11545) Refactor initiative signing wizard (#10731) Fix Permissions screen on budgets throw errors (#11532) Redesign: read more literal (#11516) ...
🎩 What? Why?
CodeClimate found that the invites queries were duplicated. This PR refactors them so they're no longer duplicated.
📌 Related Issues
Testing
All the CI should be green
📷 Screenshots
From Codeclimate:
Mind that the link will expire in a couple of weeks.